* [PATCH] net: mdio-gpio: make mdiobb_ops const
@ 2017-08-22 8:13 Bhumika Goyal
2017-08-22 13:15 ` Andrew Lunn
2017-08-22 21:23 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Bhumika Goyal @ 2017-08-22 8:13 UTC (permalink / raw)
To: julia.lawall, andrew, f.fainelli, netdev, linux-kernel; +Cc: Bhumika Goyal
Make this const as it is only stored in a const field of a
mdiobb_ctrl structure.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/net/phy/mdio-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 7faa79b..4333c6e 100644
--- a/drivers/net/phy/mdio-gpio.c
+++ b/drivers/net/phy/mdio-gpio.c
@@ -116,7 +116,7 @@ static void mdc_set(struct mdiobb_ctrl *ctrl, int what)
gpiod_set_value(bitbang->mdc, what);
}
-static struct mdiobb_ops mdio_gpio_ops = {
+static const struct mdiobb_ops mdio_gpio_ops = {
.owner = THIS_MODULE,
.set_mdc = mdc_set,
.set_mdio_dir = mdio_dir,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: mdio-gpio: make mdiobb_ops const
2017-08-22 8:13 [PATCH] net: mdio-gpio: make mdiobb_ops const Bhumika Goyal
@ 2017-08-22 13:15 ` Andrew Lunn
2017-08-22 21:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-08-22 13:15 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: julia.lawall, f.fainelli, netdev, linux-kernel
On Tue, Aug 22, 2017 at 01:43:29PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in a const field of a
> mdiobb_ctrl structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: mdio-gpio: make mdiobb_ops const
2017-08-22 8:13 [PATCH] net: mdio-gpio: make mdiobb_ops const Bhumika Goyal
2017-08-22 13:15 ` Andrew Lunn
@ 2017-08-22 21:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-08-22 21:23 UTC (permalink / raw)
To: bhumirks; +Cc: julia.lawall, andrew, f.fainelli, netdev, linux-kernel
From: Bhumika Goyal <bhumirks@gmail.com>
Date: Tue, 22 Aug 2017 13:43:29 +0530
> Make this const as it is only stored in a const field of a
> mdiobb_ctrl structure.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-22 21:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-22 8:13 [PATCH] net: mdio-gpio: make mdiobb_ops const Bhumika Goyal
2017-08-22 13:15 ` Andrew Lunn
2017-08-22 21:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).