From: David Miller <davem@davemloft.net>
To: madalin.bucur@nxp.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen
Date: Tue, 22 Aug 2017 14:35:10 -0700 (PDT) [thread overview]
Message-ID: <20170822.143510.1048652578169181274.davem@davemloft.net> (raw)
In-Reply-To: <1503423066-15420-2-git-send-email-madalin.bucur@nxp.com>
From: Madalin Bucur <madalin.bucur@nxp.com>
Date: Tue, 22 Aug 2017 20:31:01 +0300
> /**
> + * fman_get_keygen
> + *
> + * @fman: A Pointer to FMan device
> + *
> + * Get the handle to KeyGen module part of FM driver
> + *
> + * Return: Handle to KeyGen
> + */
> +struct fman_keygen *fman_get_keygen(struct fman *fman)
> +{
> + return fman->keygen;
> +}
> +EXPORT_SYMBOL(fman_get_keygen);
Please don't do this.
Just directly derefence the pointer in the source code to
get the keygen.
Thank you.
next prev parent reply other threads:[~2017-08-22 21:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 17:31 [PATCH v2 0/6] Add RSS to DPAA 1.x Ethernet driver Madalin Bucur
2017-08-22 17:31 ` [PATCH v2 1/6] fsl/fman: enable FMan Keygen Madalin Bucur
2017-08-22 21:35 ` David Miller [this message]
2017-08-23 4:36 ` Madalin-cristian Bucur
2017-08-23 4:46 ` David Miller
2017-08-23 5:16 ` Madalin-cristian Bucur
2017-08-22 17:31 ` [PATCH v2 2/6] dpaa_eth: use multiple Rx frame queues Madalin Bucur
2017-08-22 17:31 ` [PATCH v2 3/6] dpaa_eth: enable Rx hashing control Madalin Bucur
2017-08-22 17:31 ` [PATCH v2 4/6] dpaa_eth: add NETIF_F_RXHASH Madalin Bucur
2017-08-22 17:31 ` [PATCH v2 5/6] Documentation: networking: add RSS information Madalin Bucur
2017-08-22 17:31 ` [PATCH v2 6/6] dpaa_eth: check allocation result Madalin Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822.143510.1048652578169181274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).