From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][net-next] MIPS,bpf: fix missing break in switch statement
Date: Tue, 22 Aug 2017 16:18:24 -0700 (PDT) [thread overview]
Message-ID: <20170822.161824.223361546462600595.davem@davemloft.net> (raw)
In-Reply-To: <20170822224606.6273-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Tue, 22 Aug 2017 23:46:06 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a missing break causing a fall-through and setting
> ctx.use_bbit_insns to the wrong value. Fix this by adding the
> missing break.
>
> Detected with cppcheck:
> "Variable 'ctx.use_bbit_insns' is reassigned a value before the old
> one has been used. 'break;' missing?"
>
> Fixes: 8d8d18c3283f ("MIPS,bpf: Fix using smp_processor_id() in preemptible splat.")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: David Daney <david.daney@cavium.com>
Applied, thanks.
prev parent reply other threads:[~2017-08-22 23:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 22:46 [PATCH][net-next] MIPS,bpf: fix missing break in switch statement Colin King
2017-08-22 23:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822.161824.223361546462600595.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).