* [PATCH][net-next] MIPS,bpf: fix missing break in switch statement
@ 2017-08-22 22:46 Colin King
2017-08-22 23:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-08-22 22:46 UTC (permalink / raw)
Cc: netdev
From: Colin Ian King <colin.king@canonical.com>
There is a missing break causing a fall-through and setting
ctx.use_bbit_insns to the wrong value. Fix this by adding the
missing break.
Detected with cppcheck:
"Variable 'ctx.use_bbit_insns' is reassigned a value before the old
one has been used. 'break;' missing?"
Fixes: 8d8d18c3283f ("MIPS,bpf: Fix using smp_processor_id() in preemptible splat.")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: David Daney <david.daney@cavium.com>
---
arch/mips/net/ebpf_jit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/net/ebpf_jit.c b/arch/mips/net/ebpf_jit.c
index 44ddc12cbb0e..7646891c4e9b 100644
--- a/arch/mips/net/ebpf_jit.c
+++ b/arch/mips/net/ebpf_jit.c
@@ -1892,6 +1892,7 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *prog)
case CPU_CAVIUM_OCTEON2:
case CPU_CAVIUM_OCTEON3:
ctx.use_bbit_insns = 1;
+ break;
default:
ctx.use_bbit_insns = 0;
}
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH][net-next] MIPS,bpf: fix missing break in switch statement
2017-08-22 22:46 [PATCH][net-next] MIPS,bpf: fix missing break in switch statement Colin King
@ 2017-08-22 23:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-22 23:18 UTC (permalink / raw)
To: colin.king; +Cc: netdev
From: Colin King <colin.king@canonical.com>
Date: Tue, 22 Aug 2017 23:46:06 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a missing break causing a fall-through and setting
> ctx.use_bbit_insns to the wrong value. Fix this by adding the
> missing break.
>
> Detected with cppcheck:
> "Variable 'ctx.use_bbit_insns' is reassigned a value before the old
> one has been used. 'break;' missing?"
>
> Fixes: 8d8d18c3283f ("MIPS,bpf: Fix using smp_processor_id() in preemptible splat.")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Acked-by: David Daney <david.daney@cavium.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-22 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-22 22:46 [PATCH][net-next] MIPS,bpf: fix missing break in switch statement Colin King
2017-08-22 23:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).