From: David Miller <davem@davemloft.net>
To: felix.manlunas@cavium.com
Cc: netdev@vger.kernel.org, raghu.vatsavayi@cavium.com,
derek.chickles@cavium.com, satananda.burla@cavium.com
Subject: Re: [PATCH net-next] liquidio: change manner of detecting whether or not NIC firmware is loaded
Date: Wed, 23 Aug 2017 20:29:45 -0700 (PDT) [thread overview]
Message-ID: <20170823.202945.1564592947856218029.davem@davemloft.net> (raw)
In-Reply-To: <20170822194637.GA6875@felix-thinkpad.cavium.com>
From: Felix Manlunas <felix.manlunas@cavium.com>
Date: Tue, 22 Aug 2017 12:46:37 -0700
> In the NIC firmware, the 1-bit flag indicating "firmware is loaded" moved
> from SLI_SCRATCH_1 to SLI_SCRATCH_2 (these are Octeon general-purpose
> scratch registers). Make the PF driver conform to this change.
>
> Remove code that sets the "firmware is loaded" flag because it's now the
> firmware's job to do that.
>
> In the code that detects whether or not the firmware is loaded, don't just
> rely on checking the "firmware is loaded" flag because that may cause a
> rare false negative. Add code that deduces whether or not the firmware is
> loaded; that will never give a false negative.
>
> Also bump up driver version to match newer NIC firmware.
>
> Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
> Signed-off-by: Derek Chickles <derek.chickles@cavium.com>
Applied.
prev parent reply other threads:[~2017-08-24 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 19:46 [PATCH net-next] liquidio: change manner of detecting whether or not NIC firmware is loaded Felix Manlunas
2017-08-24 3:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823.202945.1564592947856218029.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=derek.chickles@cavium.com \
--cc=felix.manlunas@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=raghu.vatsavayi@cavium.com \
--cc=satananda.burla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).