From: David Miller <davem@davemloft.net>
To: david.lebrun@uclouvain.be
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/5] ipv6: sr: add support for encapsulation of L2 frames
Date: Thu, 24 Aug 2017 14:15:21 -0700 (PDT) [thread overview]
Message-ID: <20170824.141521.105174223642988977.davem@davemloft.net> (raw)
In-Reply-To: <20170823153203.11951-3-david.lebrun@uclouvain.be>
From: David Lebrun <david.lebrun@uclouvain.be>
Date: Wed, 23 Aug 2017 17:32:00 +0200
> + case SEG6_IPTUN_MODE_L2ENCAP:
> + head = sizeof(struct ipv6hdr) + 14;
> + break;
This 14 is ETH_HLEN.
>
> + if (pskb_expand_head(skb, skb->mac_len, 0, GFP_ATOMIC) < 0)
> + return -ENOMEM;
But you seem to support arbitrary L2 MAC header sizes.
Please sort this out.
next prev parent reply other threads:[~2017-08-24 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 15:31 [PATCH net-next 0/5] net: updates for IPv6 Segment Routing David Lebrun
2017-08-23 15:31 ` [PATCH net-next 1/5] ipv6: sr: add support for ip4ip6 encapsulation David Lebrun
2017-08-23 15:32 ` [PATCH net-next 2/5] ipv6: sr: add support for encapsulation of L2 frames David Lebrun
2017-08-24 21:15 ` David Miller [this message]
2017-08-23 15:32 ` [PATCH net-next 3/5] ipv6: sr: enforce IPv6 packets for seg6local lwt David Lebrun
2017-08-23 15:32 ` [PATCH net-next 4/5] ipv6: sr: add helper functions for seg6local David Lebrun
2017-08-23 15:33 ` [PATCH net-next 5/5] ipv6: sr: implement additional seg6local actions David Lebrun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824.141521.105174223642988977.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.lebrun@uclouvain.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).