From: Phil Sutter <phil@nwl.cc>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: [iproute PATCH v4 2/6] lib/fs: Fix format string in find_fs_mount()
Date: Thu, 24 Aug 2017 11:51:46 +0200 [thread overview]
Message-ID: <20170824095150.5469-3-phil@nwl.cc> (raw)
In-Reply-To: <20170824095150.5469-1-phil@nwl.cc>
A field width of 4096 allows fscanf() to store that amount of characters
into the given buffer, though that doesn't include the terminating NULL
byte. Decrease the value by one to leave space for it.
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
lib/fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/fs.c b/lib/fs.c
index c59ac564581d0..1ff881ecfcd8c 100644
--- a/lib/fs.c
+++ b/lib/fs.c
@@ -45,7 +45,7 @@ static char *find_fs_mount(const char *fs_to_find)
return NULL;
}
- while (fscanf(fp, "%*s %4096s %127s %*s %*d %*d\n",
+ while (fscanf(fp, "%*s %4095s %127s %*s %*d %*d\n",
path, fstype) == 2) {
if (strcmp(fstype, fs_to_find) == 0) {
mnt = strdup(path);
--
2.13.1
next prev parent reply other threads:[~2017-08-24 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 9:51 [iproute PATCH v4 0/6] Covscan: Fixes for string termination Phil Sutter
2017-08-24 9:51 ` [iproute PATCH v4 1/6] ipntable: Avoid memory allocation for filter.name Phil Sutter
2017-08-24 9:51 ` Phil Sutter [this message]
2017-08-24 9:51 ` [iproute PATCH v4 3/6] lib/inet_proto: Review inet_proto_{a2n,n2a}() Phil Sutter
2017-08-24 9:51 ` [iproute PATCH v4 4/6] lnstat_util: Simplify alloc_and_open() a bit Phil Sutter
2017-08-24 9:51 ` [iproute PATCH v4 5/6] tc/m_xt: Fix for potential string buffer overflows Phil Sutter
2017-08-24 9:51 ` [iproute PATCH v4 6/6] lib/ll_map: Choose size of new cache items at run-time Phil Sutter
2017-08-24 22:16 ` [iproute PATCH v4 0/6] Covscan: Fixes for string termination Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824095150.5469-3-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).