From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: davem@davemloft.net, kishon@ti.com, jason@lakedaemon.net,
sebastian.hesselbarth@gmail.com,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com, nadavh@marvell.com,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
mw@semihalf.com, stefanc@marvell.com,
miquel.raynal@free-electrons.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver
Date: Thu, 24 Aug 2017 15:45:04 +0200 [thread overview]
Message-ID: <20170824134504.GD8022@lunn.ch> (raw)
In-Reply-To: <20170824083823.16826-3-antoine.tenart@free-electrons.com>
> + for_each_available_child_of_node(pdev->dev.of_node, child) {
> + struct mvebu_comphy_lane *lane;
> + struct phy *phy;
> + int ret;
> + u32 val;
> +
> + ret = of_property_read_u32(child, "reg", &val);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "missing 'reg' property (%d)\n",
> + ret);
> + continue;
> + }
I'm just wondering why we need this. We know how many lanes there are
from the table. So just create a generic PHY for each lane?
Andrew
next prev parent reply other threads:[~2017-08-24 13:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 8:38 [PATCH net-next 00/13] net: mvpp2: comphy configuration Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the phy_mode enum Antoine Tenart
2017-08-24 13:19 ` Andrew Lunn
2017-08-24 13:31 ` Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart
2017-08-24 13:39 ` Andrew Lunn
2017-08-24 13:44 ` Antoine Tenart
2017-08-24 13:51 ` Andrew Lunn
2017-08-24 13:57 ` Stefan Chulski
2017-08-24 14:01 ` Antoine Tenart
2017-08-24 14:02 ` Andrew Lunn
2017-08-24 13:45 ` Andrew Lunn [this message]
2017-08-24 13:58 ` Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 03/13] Documentation/bindings: phy: document the Marvell " Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 04/13] net: mvpp2: initialize the comphy Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 05/13] net: mvpp2: do not force the link mode Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 06/13] net: mvpp2: simplify the link_event function Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 07/13] net: mvpp2: improve the link management function Antoine Tenart
2017-08-24 14:06 ` Andrew Lunn
2017-08-24 14:14 ` Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 08/13] net: mvpp2: check the netif is running in the link_event function Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart
2017-08-24 14:56 ` Andrew Lunn
2017-08-24 15:52 ` Antoine Tenart
2017-08-24 16:01 ` Andrew Lunn
2017-08-24 16:19 ` Antoine Tenart
2017-08-24 16:57 ` Andrew Lunn
2017-08-24 17:04 ` Russell King - ARM Linux
2017-08-24 17:13 ` Antoine Tenart
2017-08-24 17:25 ` [EXT] " Stefan Chulski
2017-08-24 17:08 ` Stefan Chulski
2017-08-24 17:14 ` Antoine Tenart
2017-08-24 17:16 ` Stefan Chulski
2017-08-25 8:19 ` Russell King - ARM Linux
2017-08-24 16:59 ` Russell King - ARM Linux
2017-08-24 17:45 ` Andrew Lunn
2017-08-24 22:16 ` Russell King - ARM Linux
2017-08-24 8:38 ` [PATCH net-next 10/13] arm64: dts: marvell: extend the cp110 syscon register area length Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 11/13] arm64: dts: marvell: add comphy nodes on cp110 master and slave Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 12/13] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart
2017-08-24 13:58 ` Andrew Lunn
2017-08-24 14:03 ` Antoine Tenart
2017-08-24 8:38 ` [PATCH net-next 13/13] arm64: defconfig: enable Marvell CP110 comphy Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824134504.GD8022@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).