netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, nic_swsd@realtek.com, romieu@fr.zoreil.com,
	edumazet@gmail.com, alexander.h.duyck@intel.com,
	sgruszka@redhat.com, Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net 0/2] r8169: Be drop monitor friendly
Date: Thu, 24 Aug 2017 18:34:42 -0700	[thread overview]
Message-ID: <20170825013444.27326-1-f.fainelli@gmail.com> (raw)

Hi all,

First patch may be questionable but no other driver appears to be doing that
and while it is defendable to account for left packets as dropped during TX
clean, this appears misleadning. I picked Stanislaw changes which brings us
back to 2010, but this was present from pre-git days as well.

Second patch fixes the two missing calls to dev_consume_skb_any().

Florian Fainelli (2):
  r8169: Do not increment tx_dropped in TX ring cleaning
  r8169: Be drop monitor friendly

 drivers/net/ethernet/realtek/r8169.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
2.9.3

             reply	other threads:[~2017-08-25  1:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  1:34 Florian Fainelli [this message]
2017-08-25  1:34 ` [PATCH net 1/2] r8169: Do not increment tx_dropped in TX ring cleaning Florian Fainelli
2017-08-25  1:34 ` [PATCH net 2/2] r8169: Be drop monitor friendly Florian Fainelli
  -- strict thread matches above, loose matches on Subject: below --
2017-08-25  1:33 [PATCH net 0/2] " Florian Fainelli
2017-08-26  2:13 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825013444.27326-1-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=romieu@fr.zoreil.com \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).