[net-next:master 1324/1341] drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table_register'

[net-next:master 1324/1341] drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table_register'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2474 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   39a7e5892418514db114ea4842d7d88aee6a61b8
commit: ffd3cdccf214cf0df08856a6738544076c4cd548 [1324/1341] devlink: Add support for dynamic table size
config: i386-randconfig-sb0-08250550 (attached as .config)
compiler: gcc-5 (Debian 5.4.1-2) 5.4.1 20160904
reproduce:
        git checkout ffd3cdccf214cf0df08856a6738544076c4cd548
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_erif_table_init':
>> drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table_register'
     return devlink_dpipe_table_register(devlink,
            ^
   In file included from drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:36:0:
   include/net/devlink.h:401:1: note: declared here
    devlink_dpipe_table_register(struct devlink *devlink,
    ^
   drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:327:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +/devlink_dpipe_table_register +323 drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c

d54b70fe Arkadi Sharshevsky 2017-03-28  318  
d54b70fe Arkadi Sharshevsky 2017-03-28  319  static int mlxsw_sp_dpipe_erif_table_init(struct mlxsw_sp *mlxsw_sp)
d54b70fe Arkadi Sharshevsky 2017-03-28  320  {
d54b70fe Arkadi Sharshevsky 2017-03-28  321  	struct devlink *devlink = priv_to_devlink(mlxsw_sp->core);
d54b70fe Arkadi Sharshevsky 2017-03-28  322  
d54b70fe Arkadi Sharshevsky 2017-03-28 @323  	return devlink_dpipe_table_register(devlink,
d54b70fe Arkadi Sharshevsky 2017-03-28  324  					    MLXSW_SP_DPIPE_TABLE_NAME_ERIF,
d54b70fe Arkadi Sharshevsky 2017-03-28  325  					    &mlxsw_sp_erif_ops,
ffd3cdcc Arkadi Sharshevsky 2017-08-24  326  					    mlxsw_sp, false);
d54b70fe Arkadi Sharshevsky 2017-03-28  327  }
d54b70fe Arkadi Sharshevsky 2017-03-28  328  

:::::: The code at line 323 was first introduced by commit
:::::: d54b70feb696f0d110626438432d0acec3cb4752 mlxsw: spectrum: Add definition for egress rif table

:::::: TO: Arkadi Sharshevsky <arkadis@mellanox.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31313 bytes --]

Re: [net-next:master 1324/1341] drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table_register'

[David Miller]

From: kbuild test robot <fengguang.wu@intel.com>
Date: Fri, 25 Aug 2017 08:03:28 +0800

> All errors (new ones prefixed by >>):
> 
>    drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_erif_table_init':
>>> drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table_register'
>      return devlink_dpipe_table_register(devlink,
>             ^
>    In file included from drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:36:0:
>    include/net/devlink.h:401:1: note: declared here
>     devlink_dpipe_table_register(struct devlink *devlink,
>     ^
>    drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:327:1: warning: control reaches end of non-void function [-Wreturn-type]
>     }
>     ^

I'll push the following fix into net-next for this:

====================
>From 790c6056686cc4dd5b149b330bbd5ae208d4d721 Mon Sep 17 00:00:00 2001
From: "David S. Miller" <davem@davemloft.net>
Date: Thu, 24 Aug 2017 18:10:46 -0700
Subject: [PATCH] devlink: Fix devlink_dpipe_table_register() stub signature.

One too many arguments compared to the non-stub version.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: ffd3cdccf214 ("devlink: Add support for dynamic table size")
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/net/devlink.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/net/devlink.h b/include/net/devlink.h
index 047a0c54f652..aaf7178127a2 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -402,8 +402,7 @@ static inline int
 devlink_dpipe_table_register(struct devlink *devlink,
 			     const char *table_name,
 			     struct devlink_dpipe_table_ops *table_ops,
-			     void *priv, u64 size,
-			     bool counter_control_extern)
+			     void *priv, bool counter_control_extern)
 {
 	return 0;
 }
-- 
2.13.5

Re: [net-next:master 1324/1341] drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table_register'

[Arkadi Sharshevsky]

On 08/25/2017 04:11 AM, David Miller wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> Date: Fri, 25 Aug 2017 08:03:28 +0800
> 
>> All errors (new ones prefixed by >>):
>>
>>    drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_erif_table_init':
>>>> drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table_register'
>>      return devlink_dpipe_table_register(devlink,
>>             ^
>>    In file included from drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:36:0:
>>    include/net/devlink.h:401:1: note: declared here
>>     devlink_dpipe_table_register(struct devlink *devlink,
>>     ^
>>    drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:327:1: warning: control reaches end of non-void function [-Wreturn-type]
>>     }
>>     ^
> 
> I'll push the following fix into net-next for this:
> 
> ====================
> From 790c6056686cc4dd5b149b330bbd5ae208d4d721 Mon Sep 17 00:00:00 2001
> From: "David S. Miller" <davem@davemloft.net>
> Date: Thu, 24 Aug 2017 18:10:46 -0700
> Subject: [PATCH] devlink: Fix devlink_dpipe_table_register() stub signature.
> 
> One too many arguments compared to the non-stub version.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: ffd3cdccf214 ("devlink: Add support for dynamic table size")
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
>  include/net/devlink.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/net/devlink.h b/include/net/devlink.h
> index 047a0c54f652..aaf7178127a2 100644
> --- a/include/net/devlink.h
> +++ b/include/net/devlink.h
> @@ -402,8 +402,7 @@ static inline int
>  devlink_dpipe_table_register(struct devlink *devlink,
>  			     const char *table_name,
>  			     struct devlink_dpipe_table_ops *table_ops,
> -			     void *priv, u64 size,
> -			     bool counter_control_extern)
> +			     void *priv, bool counter_control_extern)
>  {
>  	return 0;
>  }
> 

Thank you, sorry for the mistake.