From: Jakub Kicinski <kubakici@wp.pl>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH] net: limit maximum number of packets to mark with xmit_more
Date: Fri, 25 Aug 2017 15:34:18 -0400 [thread overview]
Message-ID: <20170825153418.53864810@cakuba> (raw)
In-Reply-To: <20170825152449.29790-1-jacob.e.keller@intel.com>
On Fri, 25 Aug 2017 08:24:49 -0700, Jacob Keller wrote:
> Under some circumstances, such as with many stacked devices, it is
> possible that dev_hard_start_xmit will bundle many packets together, and
> mark them all with xmit_more.
Excuse my ignorance but what are those stacked devices? Could they
perhaps be fixed somehow? My intuition was that long xmit_more
sequences can only happen if NIC and/or BQL are back pressuring, and
therefore we shouldn't be seeing a long xmit_more "train" arriving at
an empty device ring...
next prev parent reply other threads:[~2017-08-25 19:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 15:24 [RFC PATCH] net: limit maximum number of packets to mark with xmit_more Jacob Keller
2017-08-25 15:36 ` Waskiewicz Jr, Peter
2017-08-25 15:58 ` Stephen Hemminger
2017-08-25 16:24 ` Keller, Jacob E
2017-08-25 22:33 ` Alexander Duyck
2017-08-28 20:46 ` Keller, Jacob E
2017-08-25 19:34 ` Jakub Kicinski [this message]
2017-08-28 20:56 ` Keller, Jacob E
2017-08-29 13:35 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825153418.53864810@cakuba \
--to=kubakici@wp.pl \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox