From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
davem@davemloft.net, kishon@ti.com, andrew@lunn.ch,
jason@lakedaemon.net, sebastian.hesselbarth@gmail.com,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com, nadavh@marvell.com,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
mw@semihalf.com, stefanc@marvell.com,
miquel.raynal@free-electrons.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 08/14] net: mvpp2: check the netif is running in the link_event function
Date: Fri, 25 Aug 2017 19:09:20 +0200 [thread overview]
Message-ID: <20170825170920.GA2568@kwain> (raw)
In-Reply-To: <1faa09d8-305a-f6d2-facf-d28f336c849a@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
Hi Florian,
On Fri, Aug 25, 2017 at 09:49:15AM -0700, Florian Fainelli wrote:
> On 08/25/2017 07:48 AM, Antoine Tenart wrote:
> > This patch adds an extra check when the link_event function is called,
> > so that it won't do anything when the netif isn't running.
>
> Why is this needed? Are you possibly starting the PHY state machine
> earlier than your ndo_open() call? Looking quickly through the driver
> does not suggest this is going on since you properly connect to the PHY
> in mvpp2_open() and start the PHY there.
I added some checks while working on this, and kept this one. But I
looked at the driver again and I assume you're right and the patch could
be dropped.
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-25 17:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 14:48 [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 01/14] phy: add sgmii and 10gkr modes to the phy_mode enum Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 02/14] phy: add the mvebu cp110 comphy driver Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 03/14] Documentation/bindings: phy: document the Marvell " Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 04/14] net: mvpp2: initialize the comphy Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart
2017-08-25 22:43 ` Russell King - ARM Linux
2017-08-28 6:55 ` Antoine Tenart
2017-08-28 8:38 ` Marcin Wojtas
2017-08-28 8:51 ` Russell King - ARM Linux
2017-08-28 9:40 ` Antoine Tenart
2017-08-28 11:06 ` Russell King - ARM Linux
2017-08-28 11:32 ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 06/14] net: mvpp2: simplify the link_event function Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 07/14] net: mvpp2: improve the link management function Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 08/14] net: mvpp2: check the netif is running in the link_event function Antoine Tenart
2017-08-25 16:49 ` Florian Fainelli
2017-08-25 17:09 ` Antoine Tenart [this message]
2017-08-25 14:48 ` [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart
2017-08-25 22:46 ` Russell King - ARM Linux
2017-08-28 6:52 ` Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 10/14] arm64: dts: marvell: extend the cp110 syscon register area length Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 11/14] arm64: dts: marvell: add comphy nodes on cp110 master and slave Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 12/14] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 13/14] arm64: dts: marvell: 7040-db: " Antoine Tenart
2017-08-25 14:48 ` [PATCH net-next v2 14/14] arm64: defconfig: enable Marvell CP110 comphy Antoine Tenart
2017-08-25 15:51 ` [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Andrew Lunn
2017-08-25 15:56 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825170920.GA2568@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).