From: Jiri Benc <jbenc@redhat.com>
To: Yi Yang <yi.y.yang@intel.com>
Cc: netdev@vger.kernel.org, dev@openvswitch.org, e@erig.me,
blp@ovn.org, jan.scheurich@ericsson.com
Subject: Re: [PATCH net-next v6 2/3] net: gso: Add GSO support for NSH
Date: Sat, 26 Aug 2017 01:22:31 +0200 [thread overview]
Message-ID: <20170826012231.3c8ceb95@griffin> (raw)
In-Reply-To: <20170825182514.6ff6c36b@griffin>
On Fri, 25 Aug 2017 18:25:14 +0200, Jiri Benc wrote:
> While looking at this, I realized that GSO for VXLAN-GPE is broken,
> too. Let me fix it by implementing what I described above which will
> make your patch much easier.
Okay, it's not really broken and we don't need that complexity. At
least not immediately. Hw offloading in the VXLAN-GPE case probably does
not work correctly and would benefit from that change but that's a
different beast to tackle at a different time. Software segmentation
works fine for VXLAN-GPE.
There should not be much problems with NSH segmentation, either, if we
carefully store and set mac_header, mac_len and skb->protocol around
calls to skb_mac_gso_segment. Note that with zero mac_len (and correct
skb->protocol), skb_mac_gso_segment behaves in the same way that you
tried to achieve with find_gso_segment_by_type, which is thus completely
unnecessary.
More on Monday.
Jiri
next prev parent reply other threads:[~2017-08-25 23:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 14:20 [PATCH net-next v6 0/3] openvswitch: add NSH support Yi Yang
2017-08-25 14:20 ` [PATCH net-next v6 1/3] net: add NSH header structures and helpers Yi Yang
2017-08-25 15:07 ` Jiri Benc
2017-08-25 14:20 ` [PATCH net-next v6 2/3] net: gso: Add GSO support for NSH Yi Yang
2017-08-25 16:25 ` Jiri Benc
2017-08-25 23:22 ` Jiri Benc [this message]
2017-08-25 14:20 ` [PATCH net-next v6 3/3] openvswitch: enable NSH support Yi Yang
2017-08-30 9:53 ` Hannes Frederic Sowa
[not found] ` <87wp5l7560.fsf-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org>
2017-08-30 11:36 ` Mooney, Sean K
2017-08-30 15:15 ` [ovs-dev] " Hannes Frederic Sowa
[not found] ` <87inh56q8u.fsf-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org>
2017-08-30 19:00 ` Mooney, Sean K
2017-08-31 12:49 ` [ovs-dev] " Hannes Frederic Sowa
2017-09-04 9:38 ` Jan Scheurich
2017-09-04 11:45 ` Hannes Frederic Sowa
2017-09-01 12:11 ` Jan Scheurich
2017-09-04 2:38 ` Yang, Yi
2017-09-04 11:22 ` Hannes Frederic Sowa
2017-09-04 11:57 ` Jan Scheurich
[not found] ` <87mv6abte5.fsf-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org>
2017-09-05 2:11 ` Yang, Yi
[not found] ` <20170905021112.GA86057-re2EX8HDrk21gSHoDXDV2kEOCMrvLtNR@public.gmane.org>
2017-09-05 10:30 ` Hannes Frederic Sowa
[not found] ` <87vakxsaj2.fsf-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org>
2017-09-05 11:38 ` Yang, Yi
[not found] ` <20170905113848.GC92895-re2EX8HDrk21gSHoDXDV2kEOCMrvLtNR@public.gmane.org>
2017-09-05 13:12 ` Hannes Frederic Sowa
[not found] ` <878thtmgra.fsf-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org>
2017-09-06 0:53 ` Yang, Yi
[not found] ` <20170906005359.GA103260-re2EX8HDrk21gSHoDXDV2kEOCMrvLtNR@public.gmane.org>
2017-09-06 8:03 ` Hannes Frederic Sowa
[not found] ` <87o9qo9ru6.fsf-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org>
2017-09-06 8:27 ` Jan Scheurich
[not found] ` <CFF8EF42F1132E4CBE2BF0AB6C21C58D787F5D2E-hqolJogE5njKJFWPz4pdheaU1rCVNFv4@public.gmane.org>
2017-09-06 9:37 ` Hannes Frederic Sowa
[not found] ` <87bmmo9ngt.fsf-tFNcAqjVMyqKXQKiL6tip0B+6BGkLq7r@public.gmane.org>
2017-09-06 9:54 ` Jan Scheurich
2017-09-06 10:02 ` Hannes Frederic Sowa
2017-09-06 11:03 ` Yang, Yi
2017-09-05 12:19 ` Jan Scheurich
[not found] ` <CFF8EF42F1132E4CBE2BF0AB6C21C58D787F5650-hqolJogE5njKJFWPz4pdheaU1rCVNFv4@public.gmane.org>
2017-09-05 13:34 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170826012231.3c8ceb95@griffin \
--to=jbenc@redhat.com \
--cc=blp@ovn.org \
--cc=dev@openvswitch.org \
--cc=e@erig.me \
--cc=jan.scheurich@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=yi.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).