netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
	Jeffy Chen <jeffy.chen@rock-chips.com>,
	stable <stable@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	rvaswani@nvidia.com, Brian Norris <briannorris@chromium.org>,
	dmitry.torokhov@gmail.com,
	Douglas Anderson <dianders@chromium.org>,
	acho@suse.com, Johan Hedberg <johan.hedberg@gmail.com>,
	Network Development <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Gustavo F. Padovan" <gustavo@padovan.org>
Subject: Re: Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session]
Date: Sun, 27 Aug 2017 15:10:14 +0200	[thread overview]
Message-ID: <20170827131014.GA10491@kroah.com> (raw)
In-Reply-To: <E0E7758A-9E4C-4179-8403-D8895424586B@holtmann.org>

On Wed, Aug 23, 2017 at 08:14:15PM +0200, Marcel Holtmann wrote:
> Hi Jiri,
> 
> >>> It looks like bnep_session has same pattern as the issue reported in
> >>> old rfcomm:
> >>> 
> >>> 	while (1) {
> >>> 		set_current_state(TASK_INTERRUPTIBLE);
> >>> 		if (condition)
> >>> 			break;
> >>> 		// may call might_sleep here
> >>> 		schedule();
> >>> 	}
> >>> 	__set_current_state(TASK_RUNNING);
> >>> 
> >>> Which fixed at:
> >>> 	dfb2fae Bluetooth: Fix nested sleeps
> >>> 
> >>> So let's fix it at the same way, also follow the suggestion of:
> >>> https://lwn.net/Articles/628628/
> > 
> > ...
> > 
> >> all 3 patches have been applied to bluetooth-next tree.
> > 
> > Hi,
> > 
> > given users are hitting it in at least 4.4 and 4.12, can we have all
> > three in all stables where this applies?
> > 
> > 5da8e47d849d Bluetooth: hidp: fix possible might sleep error in
> > hidp_session_thread
> > f06d977309d0 Bluetooth: cmtp: fix possible might sleep error in cmtp_session
> > 25717382c1dd Bluetooth: bnep: fix possible might sleep error in bnep_session
> > 
> > I am not sure: to stable directly or via net stable?
> 
> as Dave said, just email -stable directly and have Greg pick them up.

All now picked up :)

      reply	other threads:[~2017-08-27 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  9:34 [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session Jeffy Chen
2017-06-27  9:34 ` [RESEND PATCH v4 2/3] Bluetooth: cmtp: fix possible might sleep error in cmtp_session Jeffy Chen
     [not found] ` <1498556084-25346-1-git-send-email-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-06-27  9:34   ` [RESEND PATCH v4 3/3] Bluetooth: hidp: fix possible might sleep error in hidp_session_thread Jeffy Chen
2017-06-27 17:32 ` [RESEND PATCH v4 1/3] Bluetooth: bnep: fix possible might sleep error in bnep_session Marcel Holtmann
2017-08-23  7:29   ` Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session] Jiri Slaby
2017-08-23 18:07     ` Stable apply request David Miller
2017-08-23 18:14     ` Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep_session] Marcel Holtmann
2017-08-27 13:10       ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170827131014.GA10491@kroah.com \
    --to=greg@kroah.com \
    --cc=acho@suse.com \
    --cc=briannorris@chromium.org \
    --cc=davem@davemloft.net \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gustavo@padovan.org \
    --cc=jeffy.chen@rock-chips.com \
    --cc=johan.hedberg@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=netdev@vger.kernel.org \
    --cc=rvaswani@nvidia.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).