* [PATCH] net: missing call of trace_napi_poll in busy_poll_stop
@ 2017-08-25 13:04 Jesper Dangaard Brouer
2017-08-28 18:23 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2017-08-25 13:04 UTC (permalink / raw)
To: netdev; +Cc: Jesper Dangaard Brouer
Noticed that busy_poll_stop() also invoke the drivers napi->poll()
function pointer, but didn't have an associated call to trace_napi_poll()
like all other call sites.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
net/core/dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 270b54754821..a24d2fb691ed 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5319,6 +5319,7 @@ static void busy_poll_stop(struct napi_struct *napi, void *have_poll_lock)
* Ideally, a new ndo_busy_poll_stop() could avoid another round.
*/
rc = napi->poll(napi, BUSY_POLL_BUDGET);
+ trace_napi_poll(napi, rc, BUSY_POLL_BUDGET);
netpoll_poll_unlock(have_poll_lock);
if (rc == BUSY_POLL_BUDGET)
__napi_schedule(napi);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: missing call of trace_napi_poll in busy_poll_stop
2017-08-25 13:04 [PATCH] net: missing call of trace_napi_poll in busy_poll_stop Jesper Dangaard Brouer
@ 2017-08-28 18:23 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-28 18:23 UTC (permalink / raw)
To: brouer; +Cc: netdev
From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Fri, 25 Aug 2017 15:04:32 +0200
> Noticed that busy_poll_stop() also invoke the drivers napi->poll()
> function pointer, but didn't have an associated call to trace_napi_poll()
> like all other call sites.
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-28 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-25 13:04 [PATCH] net: missing call of trace_napi_poll in busy_poll_stop Jesper Dangaard Brouer
2017-08-28 18:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).