From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format Date: Mon, 28 Aug 2017 12:33:31 -0700 Message-ID: <20170828123331.64260385@xeon-e3> References: <20170828190738.26829-1-aring@mojatatu.com> <20170828190738.26829-3-aring@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jhs@mojatatu.com, yotamg@mellanox.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org To: Alexander Aring Return-path: Received: from mail-pg0-f43.google.com ([74.125.83.43]:35893 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbdH1Tdd (ORCPT ); Mon, 28 Aug 2017 15:33:33 -0400 Received: by mail-pg0-f43.google.com with SMTP id r133so4162879pgr.3 for ; Mon, 28 Aug 2017 12:33:33 -0700 (PDT) In-Reply-To: <20170828190738.26829-3-aring@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 28 Aug 2017 15:07:36 -0400 Alexander Aring wrote: > This patch uses the usually IEEE format to display an ethertype which is > 4-digits and every digit in upper case. > > Signed-off-by: Alexander Aring > --- > tc/m_ife.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tc/m_ife.c b/tc/m_ife.c > index e05e2276..7b57130e 100644 > --- a/tc/m_ife.c > +++ b/tc/m_ife.c > @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p, > NEXT_ARG(); > if (get_u16(&ife_type, *argv, 0)) > invarg("ife type is invalid", *argv); > - fprintf(stderr, "IFE type 0x%x\n", ife_type); > + fprintf(stderr, "IFE type 0x%04X\n", ife_type); > user_type = 1; > } else if (matches(*argv, "dst") == 0) { > NEXT_ARG(); Why upper case?