Re: [PATCH net-next v2 01/10] net: dsa: add debugfs interface

Andrew Lunn
2017-09-15T14:08:47Z

> Could you put together your requirements so we can work it out to extend
> devlink to support them?

As i've said multiple times, generic two dimensional tables. Examples
could look like:

Stats cpu lan0 lan1 lan2 lan3 lan4 dsa
---------------------------------------------------------------------
tx_packets: 2 0 0 0 0 0 0
tx_bytes: 1180 6666 0 0 0 0 0
rx_packets: 0 0 0 0 0 0 0
rx_bytes: 0 1180 0 0 0 0 0
in_good_octets: 6666 1188 0 0 0 0 0
in_bad_octets: 0 0 0 0 0 0 0
in_unicast: 0 0 0 0 0 0 0
in_broadcasts: 0 0 0 0 0 0 0
in_multicasts: 89 0 0 0 0 0 0
in_pause: 0 0 0 0 0 0 0
in_undersize: 0 0 0 0 0 0 0
in_fragments: 0 0 0 0 0 0 0
in_oversize: 0 0 0 0 0 0 0
in_jabber: 0 0 0 0 0 0 0
in_rx_error: 0 0 0 0 0 0 0
in_fcs_error: 0 0 0 0 0 0 0
out_octets: 1188 6666 0 0 0 0 0
out_unicast: 0 0 0 0 0 0 0
out_broadcasts: 2 2 0 0 0 0 0
out_multicasts: 0 89 0 0 0 0 0
out_pause: 0 0 0 0 0 0 0
excessive: 0 0 0 0 0 0 0
collisions: 0 0 0 0 0 0 0
deferred: 0 0 0 0 0 0 0
single: 0 0 0 0 0 0 0
multiple: 0 0 0 0 0 0 0
out_fcs_error: 0 0 0 0 0 0 0
late: 0 0 0 0 0 0 0
hist_64bytes: 0 0 0 0 0 0 0
hist_65_127bytes: 0 0 0 0 0 0 0
hist_128_255bytes: 0 0 0 0 0 0 0
hist_256_511bytes: 0 0 0 0 0 0 0
hist_512_1023bytes: 0 0 0 0 0 0 0
hist_1024_max_bytes: 0 0 0 0 0 0 0
sw_in_discards: 0 0 0 0 0 0 0
sw_in_filtered: 0 0 0 0 0 0 0
sw_out_filtered: 89 89 0 0 0 0 0

Reg cpu lan0 lan1 lan2 lan3 lan4 lan5 global0 global1
-----------------------------------------------------------------------------
00: 4e07 4d04 4d04 4d04 4d04 4d04 4d04 0000 00000
01: 403e 003d 003d 003d 003d 003d 003d 0000 00000
02: 0000 0000 0000 0000 0000 0000 0000 0000 00000
03: 3521 3521 3521 3521 3521 3521 3521 0000 00000
04: 0533 373f 373f 373f 373f 373f 373f 0000 00000
05: 8000 0000 0000 0000 0000 0000 0000 0000 00000
06: 005f 003f 003f 003f 003f 003f 003f 0000 00000
07: 002a 002a 002a 002a 002a 002a 002a 0000 00000
08: 2080 2080 2080 2080 2080 2080 2080 0000 00000
09: 0001 0001 0001 0001 0001 0001 0001 0000 00000
0a: 0000 0000 0000 0000 0000 0000 0000 0000 00000
0b: 0020 0000 0000 0000 0000 0000 0000 0000 00000
0c: 0000 0000 0000 0000 0000 0000 0000 0000 00000
0d: 0000 0000 0000 0000 0000 0000 0000 0000 00000
0e: 0000 0000 0000 0000 0000 0000 0000 0000 00000
0f: 9100 dada dada dada dada dada dada 0000 00000
10: 0000 0000 0000 0000 0000 0000 0000 0000 00000
11: 0000 0000 0000 0000 0000 0000 0000 0000 00000
12: 0000 0000 0000 0000 0000 0000 0000 0000 00000
13: 0000 00d8 00d8 00d8 00d8 00d8 00d8 0000 00000
14: 0000 0000 0000 0000 0000 0000 0000 0000 00000
15: 0000 0000 0000 0000 0000 0000 0000 0000 00000
16: 0022 0000 0000 0000 0000 0000 0000 0000 00000
17: 0000 0000 0000 0000 0000 0000 0000 0000 00000
18: 3210 2210 2210 2210 2210 2210 2210 0000 00000
19: 7654 7654 7654 7654 7654 7654 7654 0000 00000
1a: 0000 0000 0000 0000 0000 0000 0000 0000 00000
1b: 8000 8000 8000 8000 8000 8000 8000 0000 00000
1c: 0000 0000 0000 0000 0000 0000 0000 0000 00000
1d: 0000 0000 0000 0000 0000 0000 0000 0000 00000
1e: 0000 0000 0000 0000 0000 0000 0000 0000 00000
1f: 0000 0000 0000 0000 0000 0000 0000 0000 00000

So a table would have an optional header row. Then a number of data
rows. The number of columns is the same for each row. The number of
columns is determined at run time, but is known at the beginning of
enumerating the table. The number of data rows is not known until the
last one is enumerated.

Each cell in the row is typed. Can be a string, bool, u8, u16, u32, u64,
ifindex, MAC address, IP address, devlink port, ....

Each cell in a row can have a different type. The types of the header
row cells can be different to the types of the data cells. All data
rows have the same type information. So you can enumerate the types
once, and use them for the whole table.

The userspace tool should make its best effort to print the table,
using the type info. It might need hits from the command line, like -x
to print in hex not decimal. The second example shows this. Registers
make more sense in hex, where as statistics make more sense in
decimal. But let the user choose, so keeping the kAPI simple. This is
intended as a debug tool. The output does not need to be highly
polished. But it needs to be a lot more readable than the current
dpipe output which prints a table as a list, not a table.

The tables can be per port, or per switch. Remember that DSA allows a
cluster of switches within one DSA instance.

Vivien, Florian, did i miss anything?

Andrew