From: "Michael S. Tsirkin" <mst@redhat.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
Jason Wang <jasowang@redhat.com>,
virtualization@lists.linux-foundation.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support
Date: Tue, 29 Aug 2017 23:38:06 +0300 [thread overview]
Message-ID: <20170829233525-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAF=yD-L95x1EPKFeiPiZ2hbTzwYmDaG9O54+0tUW_4opuRKDMw@mail.gmail.com>
On Tue, Aug 29, 2017 at 04:27:41PM -0400, Willem de Bruijn wrote:
> On Tue, Aug 29, 2017 at 4:16 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Aug 29, 2017 at 04:07:59PM -0400, Willem de Bruijn wrote:
> >> From: Willem de Bruijn <willemb@google.com>
> >>
> >> Implement a mechanism to signal that a virtio device implements the
> >> VIRTIO_CONFIG_S_NEEDS_RESET command.
> >>
> >> Testing for VIRTIO_CONFIG_S_NEEDS_RESET support by issuing the request
> >> and verifying the reset state would require an expensive state change.
> >>
> >> To avoid that, add a status bit to the feature register used during
> >> feature negotiation between host and guest.
> >>
> >> Set the bit for virtio-net, which supports the feature.
> >>
> >> Signed-off-by: Willem de Bruijn <willemb@google.com>
> >
> > All virtio 1 devices have the reset feature
>
> I don't quite follow. No device drivers implement this request currently?
Depends. Spec 1.0 describes the bit and that driver can respond
by reseting the device. You seem to do something else
in this patchset, but as designed in 1.0 it does not seem to need
a feature bit.
> > so maybe guest does
> > not need this flag. Does device need it? Does device really
> > care that guest can't recover?
>
> If all device drivers support it, then the flag is not needed.
>
> But as long as legacy device drivers can exist that do not support
> this feature, it has to have a way of differentiating between the two.
Why? Device won't set this unless it's in a bad state. In that case,
setting the bit is harmless even if drivers ignore it.
--
MST
next prev parent reply other threads:[~2017-08-29 20:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 20:07 [PATCH RFC 0/2] virtio-net: implement reset request Willem de Bruijn
2017-08-29 20:07 ` [PATCH RFC 1/2] virtio_net: implement VIRTIO_CONFIG_S_NEEDS_RESET Willem de Bruijn
2017-08-29 20:20 ` Michael S. Tsirkin
2017-10-05 16:18 ` Willem de Bruijn
2017-08-29 20:07 ` [PATCH RFC 2/2] virtio_net: enable probing for NEEDS_RESET support Willem de Bruijn
2017-08-29 20:16 ` Michael S. Tsirkin
2017-08-29 20:27 ` Willem de Bruijn
2017-08-29 20:38 ` Michael S. Tsirkin [this message]
2017-08-29 21:02 ` Willem de Bruijn
2017-08-29 21:13 ` Michael S. Tsirkin
2017-08-29 22:38 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829233525-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).