From: David Miller <davem@davemloft.net>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
samuel@sortiz.org, linux-kernel@vger.kernel.org,
fengguang.wu@intel.com, geert@linux-m68k.org
Subject: Re: [PATCH v3 net-next] staging: irda: fix init level for irda core
Date: Wed, 30 Aug 2017 10:15:32 -0700 (PDT) [thread overview]
Message-ID: <20170830.101532.1535425571044102908.davem@davemloft.net> (raw)
In-Reply-To: <20170830111649.GA13000@kroah.com>
From: Greg KH <gregkh@linuxfoundation.org>
Date: Wed, 30 Aug 2017 13:16:49 +0200
> When moving the IRDA code out of net/ into drivers/staging/irda/net, the
> link order changes when IRDA is built into the kernel. That causes a
> kernel crash at boot time as netfilter isn't initialized yet.
>
> To fix this, move the init call level of the irda core to be
> device_initcall() as the link order keeps this being initialized at the
> correct time.
>
> Reported-by: kernel test robot <fengguang.wu@intel.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>
> v3 - just change the initcall level, works so much simpler, thanks to
> DaveM for the idea.
> v2 - don't force irda to be a module, make the Makefiles put irda back
> where it was before in the link order.
Applied, thanks for following up on this Greg.
next prev parent reply other threads:[~2017-08-30 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 7:09 [PATCH net-next] staging: irda: update MAINTAINERS Greg Kroah-Hartman
2017-08-29 9:14 ` [PATCH net-next] staging: irda: force to be a kernel module Greg Kroah-Hartman
2017-08-29 16:35 ` David Miller
2017-08-29 17:26 ` Greg KH
2017-08-29 17:31 ` Greg KH
2017-08-29 17:46 ` [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel Greg KH
2017-08-29 17:49 ` David Miller
2017-08-29 19:05 ` Greg KH
2017-08-30 11:16 ` [PATCH v3 net-next] staging: irda: fix init level for irda core Greg KH
2017-08-30 17:15 ` David Miller [this message]
2017-08-29 17:40 ` [PATCH net-next] staging: irda: force to be a kernel module David Miller
2017-08-29 16:30 ` [PATCH net-next] staging: irda: update MAINTAINERS David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830.101532.1535425571044102908.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=fengguang.wu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).