From: Jiri Benc <jbenc@redhat.com>
To: "Yang, Yi" <yi.y.yang@intel.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"e@erig.me" <e@erig.me>,
"jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>,
"blp@ovn.org" <blp@ovn.org>
Subject: Re: [PATCH net-next 0/4] nsh: headers, GSO
Date: Wed, 30 Aug 2017 09:20:40 +0200 [thread overview]
Message-ID: <20170830092040.61e5f09b@griffin> (raw)
In-Reply-To: <20170830052303.GA109175@cran64.bj.intel.com>
On Wed, 30 Aug 2017 13:23:04 +0800, Yang, Yi wrote:
> David has merged your NSH GSO series, do you have one more patch series
> to fix VxLAN-gpe+NSH GSO issue? I think we still need do something in
> skb_udp_tunnel_segment in net/ipv4/udp_offload.c to support
> VxLAN-gpe+NSH GSO.
This should work as is.
The only issue is VXLAN-GPE offloading where not all drivers distinguish
VXLAN from VXLAN-GPE in ndo_features_check, while I'm not sure their
firmware actually supports VXLAN-GPE. We don't make it easy for the
drivers to distinguish those two, the only way is to examine the
headers. We could do better here but that's for future improvement.
> I'll post new OVS NSH kernel datapath patch series if NSH GSO is done.
Please do. Note that it's important to ensure that whenever there's a
NSH header added, the nsh module gets loaded. The easiest way is to
factor out code that will be shared by the NSH tc action into nsh.c.
This would have to be done anyway so let's do it right away.
Jiri
next prev parent reply other threads:[~2017-08-30 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 19:43 [PATCH net-next 0/4] nsh: headers, GSO Jiri Benc
2017-08-28 19:43 ` [PATCH net-next 1/4] ether: add NSH ethertype Jiri Benc
2017-08-28 19:43 ` [PATCH net-next 2/4] vxlan: factor out VXLAN-GPE next protocol Jiri Benc
2017-08-28 19:43 ` [PATCH net-next 3/4] net: add NSH header structures and helpers Jiri Benc
2017-08-29 17:10 ` Jiri Benc
2017-08-28 19:43 ` [PATCH net-next 4/4] nsh: add GSO support Jiri Benc
2017-08-29 22:17 ` [PATCH net-next 0/4] nsh: headers, GSO David Miller
2017-08-30 5:23 ` Yang, Yi
2017-08-30 7:20 ` Jiri Benc [this message]
2017-08-30 7:19 ` Yang, Yi
2017-08-30 7:44 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830092040.61e5f09b@griffin \
--to=jbenc@redhat.com \
--cc=blp@ovn.org \
--cc=davem@davemloft.net \
--cc=e@erig.me \
--cc=jan.scheurich@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=yi.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).