From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] net: mdio-mux: Misc fix
Date: Wed, 30 Aug 2017 21:01:19 +0200 [thread overview]
Message-ID: <20170830190119.GK22289@lunn.ch> (raw)
In-Reply-To: <20170830174651.30325-1-clabbe.montjoie@gmail.com>
On Wed, Aug 30, 2017 at 07:46:46PM +0200, Corentin Labbe wrote:
> Hello
>
> This patch series fix minor problems found when working on the
> dwmac-sun8i syscon mdio-mux.
Hi Corentin
In general, a nice patchset.
Looking at the code, there are a few calls to devm_kfree() which look
redundant. This one should probably stay:
if (r) {
mdiobus_free(cb->mii_bus);
devm_kfree(dev, cb);
} else {
but i think the others can go.
Just a suggestion, not a problem if you don't feel like doing this...
Andrew
next prev parent reply other threads:[~2017-08-30 19:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 17:46 [PATCH 0/5] net: mdio-mux: Misc fix Corentin Labbe
2017-08-30 17:46 ` [PATCH 1/5] net: mdio-mux: Fix NULL Comparison style Corentin Labbe
2017-08-30 18:47 ` Andrew Lunn
2017-08-30 17:46 ` [PATCH 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message Corentin Labbe
2017-08-30 18:49 ` Andrew Lunn
2017-08-30 17:46 ` [PATCH 3/5] net: mdio-mux: printing driver version is useless Corentin Labbe
2017-08-30 18:46 ` Andrew Lunn
2017-08-30 17:46 ` [PATCH 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers Corentin Labbe
2017-08-30 18:49 ` Andrew Lunn
2017-08-30 17:46 ` [PATCH 5/5] net: mdio-mux: fix unbalanced put_device Corentin Labbe
2017-08-30 18:53 ` Andrew Lunn
2017-08-30 19:01 ` Andrew Lunn [this message]
2017-09-01 8:30 ` [PATCH 0/5] net: mdio-mux: Misc fix Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830190119.GK22289@lunn.ch \
--to=andrew@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).