From: Larry Finger <Larry.Finger@lwfinger.net>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
netdev@vger.kernel.org, Birming Chiu <birming@realtek.com>,
Steven Ting <steventing@realtek.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: [PATCH 1/2] staging: r8822be: Remove some dead code
Date: Wed, 30 Aug 2017 14:43:12 -0500 [thread overview]
Message-ID: <20170830194313.9659-2-Larry.Finger@lwfinger.net> (raw)
In-Reply-To: <20170830194313.9659-1-Larry.Finger@lwfinger.net>
The code found inside an #ifdef CONFIG_RTL_DEBUG ... #endif section
is left over from debugging of the original driver, and should be
deleted.
Reported by: Andreas Ziegler <andreas.ziegler@fau.de>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Cc: Birming Chiu <birming@realtek.com>
Cc: Shaofu <shaofu@realtek.com>
Cc: Steven Ting <steventing@realtek.com>
---
drivers/staging/rtlwifi/halmac/rtl_halmac.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/drivers/staging/rtlwifi/halmac/rtl_halmac.c b/drivers/staging/rtlwifi/halmac/rtl_halmac.c
index 031bf2c6078f..2b1c5fae64ef 100644
--- a/drivers/staging/rtlwifi/halmac/rtl_halmac.c
+++ b/drivers/staging/rtlwifi/halmac/rtl_halmac.c
@@ -386,26 +386,6 @@ static void deinit_priv(struct rtl_halmac *halmac)
u32 count, size;
count = HALMAC_FEATURE_ALL + 1;
-#ifdef CONFIG_RTL_DEBUG
- {
- struct submit_ctx *sctx;
- u32 i;
-
- for (i = 0; i < count; i++) {
- if (!indicator[i].sctx)
- continue;
-
- RT_TRACE(
- rtlpriv, COMP_HALMAC, DBG_LOUD,
- "%s: <WARN> %s id(%d) sctx still exist!!\n",
- __func__, RTL_HALMAC_FEATURE_NAME[i],
- i);
- sctx = indicator[i].sctx;
- indicator[i].sctx = NULL;
- rtl_mfree((u8 *)sctx, sizeof(*sctx));
- }
- }
-#endif /* !CONFIG_RTL_DEBUG */
size = sizeof(*indicator) * count;
kfree((u8 *)indicator);
}
--
2.12.3
next prev parent reply other threads:[~2017-08-30 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 19:43 [PATCH 0/2] staging: r8822be: Remove some left-over debug code Larry Finger
2017-08-30 19:43 ` Larry Finger [this message]
2017-08-30 19:43 ` [PATCH 2/2] staging: r8822be: Simplify deinit_priv() Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830194313.9659-2-Larry.Finger@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=birming@realtek.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=steventing@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox