From: Richard Cochran <richardcochran@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: stefan.sorensen@spectralink.com, grygorii.strashko@ti.com,
netdev@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH net-next] net: cpsw: Don't handle SIOC[GS]HWTSTAMP when CPTS is disabled
Date: Thu, 31 Aug 2017 09:48:07 +0200 [thread overview]
Message-ID: <20170831074807.3dbbt6qhqxdquipa@localhost> (raw)
In-Reply-To: <20170830.144745.947488279115809130.davem@davemloft.net>
On Wed, Aug 30, 2017 at 02:47:45PM -0700, David Miller wrote:
> It should not be required to disable a Kconfig option just to get PHY
> timestamping to work properly.
Well, if the MAC driver handles the ioctl and enables time stamping,
then the PHY driver's time stamping remains disabled. We don't have a
way to choose PHY time stamping at run time.
> Rather, if the CPTS code returns -EOPNOTSUPP we should try to
> fallthrough to the PHY library based methods.
I agree that it would be better for the core (rather than the
individual drivers) to handle this case.
There are a few callers of .ndo_do_ioctl to consider. Besides
dev_ifsioc() there is at least vlan_dev_ioctl() that needs to handle
the EOPNOTSUPP.
Thanks,
Richard
next prev parent reply other threads:[~2017-08-31 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 6:50 [PATCH net-next] net: cpsw: Don't handle SIOC[GS]HWTSTAMP when CPTS is disabled Stefan Sørensen
2017-08-30 21:47 ` David Miller
2017-08-31 7:48 ` Richard Cochran [this message]
2017-09-05 21:25 ` Grygorii Strashko
2017-09-06 8:59 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831074807.3dbbt6qhqxdquipa@localhost \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan.sorensen@spectralink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).