From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
davem@davemloft.net, gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com, nadavh@marvell.com,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
mw@semihalf.com, stefanc@marvell.com,
miquel.raynal@free-electrons.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link status changes
Date: Thu, 31 Aug 2017 15:52:55 +0200 [thread overview]
Message-ID: <20170831135255.GA26758@kwain> (raw)
In-Reply-To: <20170831134724.GO22289@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
Hi Andrew,
On Thu, Aug 31, 2017 at 03:47:24PM +0200, Andrew Lunn wrote:
> On Thu, Aug 31, 2017 at 09:12:55AM +0200, Antoine Tenart wrote:
> > +static void mvpp22_gop_unmask_irq(struct mvpp2_port *port)
> > +{
> > + u32 val;
> > +
> > + if (port->phy_interface == PHY_INTERFACE_MODE_RGMII ||
> > + port->phy_interface == PHY_INTERFACE_MODE_RGMII_ID ||
> > + port->phy_interface == PHY_INTERFACE_MODE_RGMII_RXID ||
> > + port->phy_interface == PHY_INTERFACE_MODE_RGMII_TXID ||
>
> phy_interface_mode_is_rgmii()
Right, and you already made that comment before... I'll fix it.
Thanks!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-08-31 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 7:12 [PATCH net-next 0/3] net: mvpp2: optional PHYs and GoP link irq Antoine Tenart
2017-08-31 7:12 ` [PATCH net-next 1/3] net: mvpp2: make the phy optional Antoine Tenart
2017-08-31 7:12 ` [PATCH net-next 2/3] net: mvpp2: use the GoP interrupt for link status changes Antoine Tenart
2017-08-31 13:47 ` Andrew Lunn
2017-08-31 13:52 ` Antoine Tenart [this message]
2017-08-31 7:12 ` [PATCH net-next 3/3] Documentation/bindings: net: marvell-pp2: add the link interrupt Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831135255.GA26758@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox