From: David Miller <davem@davemloft.net>
To: claudiu.manoil@nxp.com
Cc: netdev@vger.kernel.org
Subject: Re: [net 0/3] gianfar: Tx flow control fix (adjust_link)
Date: Fri, 01 Sep 2017 10:15:38 -0700 (PDT) [thread overview]
Message-ID: <20170901.101538.1176427534027457129.davem@davemloft.net> (raw)
In-Reply-To: <1504258863-2058-1-git-send-email-claudiu.manoil@nxp.com>
From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: Fri, 1 Sep 2017 12:41:00 +0300
> Fix a small blunder in the Tx pause frame settings, that
> went unnoticed in the tangled code of adjust_link().
> I followed up with a couple of simple refactoring patches,
> aiming to make adjust_link() more manageable.
>
> (The last 2 patches may be postponed if they are too much
> for the current stage of net.)
You need to fix some things up here.
First, do not mix bug fixes with cleanups. Refactoring is a cleanup.
Submit the bug fix for 'net' and then later you can submit the
cleanups for 'net-next'.
Second, do not CC: stable for networking bug fixes, instead explicitly
ask me to queue up the fix for -stable.
Third, you need to fix how you specify your Fixes tag, it must
be exactly:
Fixes: $(SHA1_ID) ("Commit header text.")
And no matter how long the line is, do not break it up.
Thank you.
prev parent reply other threads:[~2017-09-01 17:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 9:41 [net 0/3] gianfar: Tx flow control fix (adjust_link) Claudiu Manoil
2017-09-01 9:41 ` [net 1/3] gianfar: Fix Tx flow control deactivation Claudiu Manoil
2017-09-01 9:41 ` [net 2/3] gianfar: Refactor link speed update (adjust_link) Claudiu Manoil
2017-09-01 9:41 ` [net 3/3] gianfar: Refactor link flow control " Claudiu Manoil
2017-09-01 17:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901.101538.1176427534027457129.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.manoil@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).