From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: harish.patil@cavium.com, manish.chopra@cavium.com,
Dept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qlcnic: remove redundant zero check on retries counter
Date: Fri, 01 Sep 2017 10:34:08 -0700 (PDT) [thread overview]
Message-ID: <20170901.103408.279665918180927406.davem@davemloft.net> (raw)
In-Reply-To: <20170901134431.23179-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Fri, 1 Sep 2017 14:44:31 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> At the end of the do while loop the integer counter retries will
> always be zero and so the subsequent check to see if it is zero
> is always true and therefore redundant. Remove the redundant check
> and always return -EIO on this return path. Also unbreak the literal
> string in dev_err message to clean up a checkpatch warning.
>
> Detected by CoverityScan, CID#744279 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next, thanks.
prev parent reply other threads:[~2017-09-01 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 13:44 [PATCH] qlcnic: remove redundant zero check on retries counter Colin King
2017-09-01 17:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901.103408.279665918180927406.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=colin.king@canonical.com \
--cc=harish.patil@cavium.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.chopra@cavium.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).