From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] inetpeer: fix RCU lookup()
Date: Fri, 01 Sep 2017 17:33:49 -0700 (PDT) [thread overview]
Message-ID: <20170901.173349.1060795224955256278.davem@davemloft.net> (raw)
In-Reply-To: <1504299812.15310.26.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 01 Sep 2017 14:03:32 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Excess of seafood or something happened while I cooked the commit
> adding RB tree to inetpeer.
>
> Of course, RCU rules need to be respected or bad things can happen.
>
> In this particular loop, we need to read *pp once per iteration, not
> twice.
>
> Fixes: b145425f269a ("inetpeer: remove AVL implementation in favor of RB tree")
> Reported-by: John Sperbeck <jsperbeck@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Cheers for excess seafood :-)
Applied.
prev parent reply other threads:[~2017-09-02 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 21:03 [PATCH net-next] inetpeer: fix RCU lookup() Eric Dumazet
2017-09-02 0:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901.173349.1060795224955256278.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox