From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH 0/6] strlcpy() and strlcat() for iproute2
Date: Fri, 1 Sep 2017 12:12:17 -0700 [thread overview]
Message-ID: <20170901121217.33e93cf9@xeon-e3> (raw)
In-Reply-To: <20170901165256.21459-1-phil@nwl.cc>
On Fri, 1 Sep 2017 18:52:50 +0200
Phil Sutter <phil@nwl.cc> wrote:
> The following series adds my own implementations of strlcpy() and
> strlcat() in patch 1 and changes the code to make use of them in the
> following patches but the last two: Patch 5 just eliminates a line of
> useless code I found while searching for potential users of the
> introduced functions, patch 6 sanitizes a call to strncpy() in
> misc/lnstat_util.c without using strlcpy() since lnstat is not being
> linked against libutil.
>
> I implemented both functions solely based on information in libbsd's man
> pages, so they are safe to be released under the GPL.
>
> Phil Sutter (6):
> utils: Implement strlcpy() and strlcat()
> Convert the obvious cases to strlcpy()
> Convert harmful calls to strncpy() to strlcpy()
> ipxfrm: Replace STRBUF_CAT macro with strlcat()
> tc_util: No need to terminate an snprintf'ed buffer
> lnstat_util: Make sure buffer is NUL-terminated
>
> genl/ctrl.c | 2 +-
> include/utils.h | 3 +++
> ip/ipnetns.c | 3 +--
> ip/iproute_lwtunnel.c | 3 +--
> ip/ipvrf.c | 5 ++---
> ip/ipxfrm.c | 21 +++++----------------
> ip/xfrm_state.c | 2 +-
> lib/bpf.c | 3 +--
> lib/fs.c | 3 +--
> lib/inet_proto.c | 3 +--
> lib/utils.c | 19 +++++++++++++++++++
> misc/lnstat_util.c | 3 ++-
> misc/ss.c | 3 +--
> tc/em_ipset.c | 3 +--
> tc/tc_util.c | 1 -
> 15 files changed, 40 insertions(+), 37 deletions(-)
>
Applied, thanks.
prev parent reply other threads:[~2017-09-01 19:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 16:52 [iproute PATCH 0/6] strlcpy() and strlcat() for iproute2 Phil Sutter
2017-09-01 16:52 ` [iproute PATCH 1/6] utils: Implement strlcpy() and strlcat() Phil Sutter
2017-09-04 14:49 ` David Laight
2017-09-04 15:00 ` Phil Sutter
2017-09-04 18:25 ` Stephen Hemminger
2017-09-06 13:59 ` David Laight
2017-09-06 15:25 ` Stephen Hemminger
2017-09-06 16:51 ` [iproute PATCH] utils: Review " Phil Sutter
2017-09-01 16:52 ` [iproute PATCH 2/6] Convert the obvious cases to strlcpy() Phil Sutter
2017-09-01 19:13 ` Daniel Borkmann
2017-09-01 16:52 ` [iproute PATCH 3/6] Convert harmful calls to strncpy() " Phil Sutter
2017-09-01 16:52 ` [iproute PATCH 4/6] ipxfrm: Replace STRBUF_CAT macro with strlcat() Phil Sutter
2017-09-01 16:52 ` [iproute PATCH 5/6] tc_util: No need to terminate an snprintf'ed buffer Phil Sutter
2017-09-01 16:52 ` [iproute PATCH 6/6] lnstat_util: Make sure buffer is NUL-terminated Phil Sutter
2017-09-01 19:12 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901121217.33e93cf9@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).