From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device
Date: Fri, 1 Sep 2017 15:38:50 +0200 [thread overview]
Message-ID: <20170901133850.GA22289@lunn.ch> (raw)
In-Reply-To: <20170901115604.27513-6-clabbe.montjoie@gmail.com>
On Fri, Sep 01, 2017 at 01:56:04PM +0200, Corentin Labbe wrote:
> mdio_mux_uninit() call put_device (unconditionally) because of
> of_mdio_find_bus() in mdio_mux_init.
> But of_mdio_find_bus is only called if mux_bus is empty.
> If mux_bus is set, mdio_mux_uninit will print a "refcount_t: underflow"
> trace.
>
> This patch add a get_device in the other branch of "if (mux_bus)".
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-09-01 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 11:55 [PATCH v2 0/5] net: mdio-mux: Misc fix Corentin Labbe
2017-09-01 11:56 ` [PATCH v2 1/5] net: mdio-mux: Fix NULL Comparison style Corentin Labbe
2017-09-01 11:56 ` [PATCH v2 2/5] net: mdio-mux: Remove unnecessary 'out of memory' message Corentin Labbe
2017-09-01 11:56 ` [PATCH v2 3/5] net: mdio-mux: printing driver version is useless Corentin Labbe
2017-09-01 13:38 ` Andrew Lunn
2017-09-01 11:56 ` [PATCH v2 4/5] net: mdio-mux-mmioreg: Can handle 8/16/32 bits registers Corentin Labbe
2017-09-01 11:56 ` [PATCH v2 5/5] net: mdio-mux: fix unbalanced put_device Corentin Labbe
2017-09-01 13:38 ` Andrew Lunn [this message]
2017-09-01 17:26 ` [PATCH v2 0/5] net: mdio-mux: Misc fix David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901133850.GA22289@lunn.ch \
--to=andrew@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).