From: Stefan Assmann <sassmann@kpanic.de>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jeffrey.t.kirsher@intel.com, sassmann@kpanic.de
Subject: [PATCH 2/2] Revert "i40e: remove WQ_UNBOUND and the task limit of our workqueue"
Date: Fri, 1 Sep 2017 16:02:34 +0200 [thread overview]
Message-ID: <20170901140234.7840-3-sassmann@kpanic.de> (raw)
In-Reply-To: <20170901140234.7840-1-sassmann@kpanic.de>
This reverts commit 4d5957cbdecdbb77d24c1465caadd801c07afa4a.
Due to this workqueue change the eeprom check right after flashing
firmware fails, although the flash itself completed successfully.
The error observed looks like this
i40e 0000:88:00.0: eeprom check failed (-62), Tx/Rx traffic disabled
The NIC is fully operational after the flash and even after a cold boot
any follow-up eeprom checks succeed.
This needs to be investigated, but for now it should be more important
to make sure the firmware update works as expected.
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 6498da8806cb..069b6683e1b0 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -12160,14 +12160,12 @@ static int __init i40e_init_module(void)
i40e_driver_string, i40e_driver_version_str);
pr_info("%s: %s\n", i40e_driver_name, i40e_copyright);
- /* There is no need to throttle the number of active tasks because
- * each device limits its own task using a state bit for scheduling
- * the service task, and the device tasks do not interfere with each
- * other, so we don't set a max task limit. We must set WQ_MEM_RECLAIM
- * since we need to be able to guarantee forward progress even under
- * memory pressure.
+ /* we will see if single thread per module is enough for now,
+ * it can't be any worse than using the system workqueue which
+ * was already single threaded
*/
- i40e_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 0, i40e_driver_name);
+ i40e_wq = alloc_workqueue("%s", WQ_UNBOUND | WQ_MEM_RECLAIM, 1,
+ i40e_driver_name);
if (!i40e_wq) {
pr_err("%s: Failed to create workqueue\n", i40e_driver_name);
return -ENOMEM;
--
2.13.5
next prev parent reply other threads:[~2017-09-01 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 14:02 [PATCH 0/2] i40e: fix firmware update Stefan Assmann
2017-09-01 14:02 ` [PATCH 1/2] i40e: use non-locking i40e_read_nvm_word() function during nvmupdate Stefan Assmann
2017-09-01 14:02 ` Stefan Assmann [this message]
2017-09-01 19:19 ` [PATCH 0/2] i40e: fix firmware update Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901140234.7840-3-sassmann@kpanic.de \
--to=sassmann@kpanic.de \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).