From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: arm@kernel.org, dave.jiang@intel.com, netdev@vger.kernel.org,
m-karicheri2@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: ti/knav_dma: include dmaengine header
Date: Tue, 05 Sep 2017 09:12:55 -0700 (PDT) [thread overview]
Message-ID: <20170905.091255.625612405262199546.davem@davemloft.net> (raw)
In-Reply-To: <20170905083146.1289546-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 5 Sep 2017 10:31:35 +0200
> A header file cleanup apparently caused a build regression
> with one driver using the knav infrastructure:
>
> In file included from drivers/net/ethernet/ti/netcp_core.c:30:0:
> include/linux/soc/ti/knav_dma.h:129:30: error: field 'direction' has incomplete type
> enum dma_transfer_direction direction;
> ^~~~~~~~~
> drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_txpipe_open':
> drivers/net/ethernet/ti/netcp_core.c:1349:21: error: 'DMA_MEM_TO_DEV' undeclared (first use in this function); did you mean 'DMA_MEMORY_MAP'?
> config.direction = DMA_MEM_TO_DEV;
> ^~~~~~~~~~~~~~
> DMA_MEMORY_MAP
> drivers/net/ethernet/ti/netcp_core.c:1349:21: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ethernet/ti/netcp_core.c: In function 'netcp_setup_navigator_resources':
> drivers/net/ethernet/ti/netcp_core.c:1659:22: error: 'DMA_DEV_TO_MEM' undeclared (first use in this function); did you mean 'DMA_DESC_HOST'?
> config.direction = DMA_DEV_TO_MEM;
>
> As the header is no longer included implicitly through netdevice.h,
> we should include it in the header that references the enum.
>
> Fixes: 0dd5759dbb1c ("net: remove dmaengine.h inclusion from netdevice.h")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> If the cleanup patch hasn't been submitted for mainline yet, please
> add this fixup to the net-next tree, otherwise I'll merge it through
> arm-soc.
Applied to net-next.
prev parent reply other threads:[~2017-09-05 16:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 8:31 [PATCH] soc: ti/knav_dma: include dmaengine header Arnd Bergmann
2017-09-05 16:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905.091255.625612405262199546.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).