From: David Miller <davem@davemloft.net>
To: claudiu.manoil@nxp.com
Cc: netdev@vger.kernel.org
Subject: Re: [net v2] gianfar: Fix Tx flow control deactivation
Date: Tue, 05 Sep 2017 14:35:43 -0700 (PDT) [thread overview]
Message-ID: <20170905.143543.1026660660946884756.davem@davemloft.net> (raw)
In-Reply-To: <1504511128-25294-1-git-send-email-claudiu.manoil@nxp.com>
From: Claudiu Manoil <claudiu.manoil@nxp.com>
Date: Mon, 4 Sep 2017 10:45:28 +0300
> The wrong register is checked for the Tx flow control bit,
> it should have been maccfg1 not maccfg2.
> This went unnoticed for so long probably because the impact is
> hardly visible, not to mention the tangled code from adjust_link().
> First, link flow control (i.e. handling of Rx/Tx link level pause frames)
> is disabled by default (needs to be enabled via 'ethtool -A').
> Secondly, maccfg2 always returns 0 for tx_flow_oldval (except for a few
> old boards), which results in Tx flow control remaining always on
> once activated.
>
> Fixes: 45b679c9a3ccd9e34f28e6ec677b812a860eb8eb ("gianfar: Implement PAUSE frame generation support")
>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Please do not put an empty line between Fixes: and other tags. All tags
are equal and should be in one uninterrupted block of text.
Applied, and queued up for -stable, thanks.
prev parent reply other threads:[~2017-09-05 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 7:45 [net v2] gianfar: Fix Tx flow control deactivation Claudiu Manoil
2017-09-05 21:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905.143543.1026660660946884756.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.manoil@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).