From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, jiri@resnulli.us,
chrism@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
oss-drivers@netronome.com
Subject: Re: [PATCH net v2] net: sched: don't use GFP_KERNEL under spin lock
Date: Tue, 05 Sep 2017 14:49:29 -0700 (PDT) [thread overview]
Message-ID: <20170905.144929.1991448009465623628.davem@davemloft.net> (raw)
In-Reply-To: <20170905153123.13209-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 5 Sep 2017 08:31:23 -0700
> The new TC IDR code uses GFP_KERNEL under spin lock. Which leads
> to:
...
> Try to preallocate the memory with idr_prealloc(GFP_KERNEL)
> (as suggested by Eric Dumazet), and change the allocation
> flags under spin lock.
>
> Fixes: 65a206c01e8e ("net/sched: Change act_api and act_xxx modules to use IDR")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Simon Horman <simon.horman@netronome.com>
Applied, thanks.
prev parent reply other threads:[~2017-09-05 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 15:31 [PATCH net v2] net: sched: don't use GFP_KERNEL under spin lock Jakub Kicinski
2017-09-05 17:17 ` Eric Dumazet
2017-09-05 21:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905.144929.1991448009465623628.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chrism@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).