From: David Miller <davem@davemloft.net>
To: zahari.doychev@linux.com
Cc: jiri@resnulli.us, netdev@vger.kernel.org
Subject: Re: [PATCH][next v2] rocker: fix kcalloc parameter order
Date: Tue, 05 Sep 2017 14:57:40 -0700 (PDT) [thread overview]
Message-ID: <20170905.145740.1996370074892542800.davem@davemloft.net> (raw)
In-Reply-To: <20170905194958.3436-1-zahari.doychev@linux.com>
From: Zahari Doychev <zahari.doychev@linux.com>
Date: Tue, 5 Sep 2017 21:49:58 +0200
> The function calls to kcalloc use wrong parameter order and incorrect flags
> values. GFP_KERNEL is used instead of flags now and the order is corrected.
>
> The change was done using the following coccinelle script:
>
> @@
> expression E1,E2;
> type T;
> @@
>
> -kcalloc(E1, E2, sizeof(T))
> +kcalloc(E2, sizeof(T), GFP_KERNEL)
>
> Signed-off-by: Zahari Doychev <zahari.doychev@linux.com>
Applied, thank you.
prev parent reply other threads:[~2017-09-05 21:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 19:49 [PATCH][next v2] rocker: fix kcalloc parameter order Zahari Doychev
2017-09-05 21:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905.145740.1996370074892542800.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=zahari.doychev@linux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).