From: Stephen Hemminger <stephen@networkplumber.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: ast@fb.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 master 2/2] bpf: consolidate dumps to use bpf_dump_prog_info
Date: Tue, 5 Sep 2017 09:35:01 -0700 [thread overview]
Message-ID: <20170905093501.2f1fbbfc@xeon-e3> (raw)
In-Reply-To: <1e96ef342a4f34ee8c8119ee8cc1ed7092ea5ced.1504570627.git.daniel@iogearbox.net>
On Tue, 5 Sep 2017 02:24:32 +0200
Daniel Borkmann <daniel@iogearbox.net> wrote:
> Consolidate dump of prog info to use bpf_dump_prog_info() when possible.
> Moving forward, we want to have a consistent output for BPF progs when
> being dumped. E.g. in cls/act case we used to dump tag as a separate
> netlink attribute before we had BPF_OBJ_GET_INFO_BY_FD bpf(2) command.
>
> Move dumping tag into bpf_dump_prog_info() as well, and only dump the
> netlink attribute for older kernels. Also, reuse bpf_dump_prog_info()
> for XDP case, so we can dump tag and whether program was jited, which
> we currently don't show.
>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
I applied this to master, and resolved conflicts with net-next.
But the dump with JSON of xdp is now incomplete.
next prev parent reply other threads:[~2017-09-05 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 0:24 [PATCH iproute2 master 0/2] Two minor BPF updates Daniel Borkmann
2017-09-05 0:24 ` [PATCH iproute2 master 1/2] bpf: minor cleanups for bpf_trace_pipe Daniel Borkmann
2017-09-05 0:24 ` [PATCH iproute2 master 2/2] bpf: consolidate dumps to use bpf_dump_prog_info Daniel Borkmann
2017-09-05 16:35 ` Stephen Hemminger [this message]
2017-09-05 16:37 ` Daniel Borkmann
2017-09-05 16:27 ` [PATCH iproute2 master 0/2] Two minor BPF updates Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905093501.2f1fbbfc@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).