From: Stephen Hemminger <stephen@networkplumber.org>
To: Petar Penkov <ppenkov@google.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Mahesh Bandewar <maheshb@google.com>,
Willem de Bruijn <willemb@google.com>,
davem@davemloft.net, ppenkov@stanford.edu
Subject: Re: [PATCH net-next RFC 1/2] tun: enable NAPI for TUN/TAP driver
Date: Tue, 5 Sep 2017 15:51:27 -0700 [thread overview]
Message-ID: <20170905155127.0bd08fb0@xeon-e3> (raw)
In-Reply-To: <20170905223551.27925-2-ppenkov@google.com>
On Tue, 5 Sep 2017 15:35:50 -0700
Petar Penkov <ppenkov@google.com> wrote:
> Changes TUN driver to use napi_gro_receive() upon receiving packets
> rather than netif_rx_ni(). Adds flag CONFIG_TUN_NAPI that enables
> these changes and operation is not affected if the flag is disabled.
> SKBs are constructed upon packet arrival and are queued to be
> processed later.
>
> The new path was evaluated with a benchmark with the following setup:
> Open two tap devices and a receiver thread that reads in a loop for
> each device. Start one sender thread and pin all threads to different
> CPUs. Send 1M minimum UDP packets to each device and measure sending
> time for each of the sending methods:
> napi_gro_receive(): 4.90s
> netif_rx_ni(): 4.90s
> netif_receive_skb(): 7.20s
>
> Signed-off-by: Petar Penkov <ppenkov@google.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Mahesh Bandewar <maheshb@google.com>
> Cc: Willem de Bruijn <willemb@google.com>
> Cc: davem@davemloft.net
> Cc: ppenkov@stanford.edu
Why is this optional? It adds two code paths both of which need
to be tested.
next prev parent reply other threads:[~2017-09-05 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 22:35 [PATCH net-next RFC 0/2] Improve code coverage of syzkaller Petar Penkov
2017-09-05 22:35 ` [PATCH net-next RFC 1/2] tun: enable NAPI for TUN/TAP driver Petar Penkov
2017-09-05 22:51 ` Stephen Hemminger [this message]
2017-09-06 9:18 ` Willem de Bruijn
2017-09-05 22:35 ` [PATCH net-next RFC 2/2] tun: enable napi_gro_frags() " Petar Penkov
2017-09-06 18:01 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170905155127.0bd08fb0@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=ppenkov@google.com \
--cc=ppenkov@stanford.edu \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).