From: David Miller <davem@davemloft.net>
To: mmanning@brocade.com
Cc: netdev@vger.kernel.org, maheshb@google.com
Subject: Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure
Date: Thu, 07 Sep 2017 19:18:43 -0700 (PDT) [thread overview]
Message-ID: <20170907.191843.836588795188250550.davem@davemloft.net> (raw)
In-Reply-To: <1504536775-23533-1-git-send-email-mmanning@brocade.com>
From: Mike Manning <mmanning@brocade.com>
Date: Mon, 4 Sep 2017 15:52:55 +0100
> Commit f784ad3d79e5 ("ipv6: do not send RTM_DELADDR for tentative
> addresses") incorrectly assumes that no RTM_NEWADDR are sent for
> addresses in tentative state, as this does happen for the standard
> IPv6 use-case of DAD failure, see the call to ipv6_ifa_notify() in
> addconf_dad_stop(). So as a result of this change, no RTM_DELADDR is
> sent after DAD failure for a link-local when strict DAD (accept_dad=2)
> is configured, or on the next admin down in other cases. The absence
> of this notification breaks backwards compatibility and causes problems
> after DAD failure if this notification was being relied on. The
> solution is to allow RTM_DELADDR to still be sent after DAD failure.
>
> Fixes: f784ad3d79e5("ipv6: do not send RTM_DELADDR for tentative addresses")
> Signed-off-by: Mike Manning <mmanning@brocade.com>
> Cc: Mahesh Bandewar <maheshb@google.com>
Mahesh, please review this patch.
next prev parent reply other threads:[~2017-09-08 2:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-04 14:52 [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure Mike Manning
2017-09-08 2:18 ` David Miller [this message]
2017-09-18 13:06 ` Mike Manning
2017-09-19 23:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907.191843.836588795188250550.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=maheshb@google.com \
--cc=mmanning@brocade.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).