From: David Miller <davem@davemloft.net>
To: dan.carpenter@oracle.com
Cc: kishon@ti.com, antoine.tenart@free-electrons.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR()
Date: Fri, 08 Sep 2017 21:09:05 -0700 (PDT) [thread overview]
Message-ID: <20170908.210905.626281012369795940.davem@davemloft.net> (raw)
In-Reply-To: <20170908103137.zck6bw66sge4fhua@mwanda>
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 8 Sep 2017 13:31:37 +0300
> devm_ioremap_resource() never returns NULL, it only returns error
> pointers so this test needs to be changed.
>
> Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This driver apparently is going through the net tree, but netdev isn't
> listed as handling it in MAINTAINERS. Kishon, do you know what's up
> with that?
Yeah let's sort this out before I apply this fix to my tree.
next prev parent reply other threads:[~2017-09-09 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 10:31 [PATCH net] phy: mvebu-cp110: checking for NULL instead of IS_ERR() Dan Carpenter
2017-09-09 4:09 ` David Miller [this message]
2017-09-11 7:24 ` Kishon Vijay Abraham I
2017-09-11 17:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908.210905.626281012369795940.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antoine.tenart@free-electrons.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).