From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
kadlec@blackhole.kfki.hu, davem@davemloft.net
Subject: Re: [netfilter-core] [PATCH] netfilter: nat: constify rhashtable_params
Date: Fri, 8 Sep 2017 19:47:18 +0200 [thread overview]
Message-ID: <20170908174718.GA1727@salvia> (raw)
In-Reply-To: <20170908114630.GA13575@salvia>
On Fri, Sep 08, 2017 at 01:46:30PM +0200, Pablo Neira Ayuso wrote:
> On Wed, Aug 30, 2017 at 05:18:04PM +0530, Arvind Yadav wrote:
> > rhashtable_params are not supposed to change at runtime. All
> > Functions rhashtable_* working with const rhashtable_params
> > provided by <linux/rhashtable.h>. So mark the non-const structs
> > as const.
>
> Applied to nf, thanks.
Actually, I tossed this. NAT rhashtable has been reverted, so no need
for this constification anymore.
prev parent reply other threads:[~2017-09-08 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 11:48 [PATCH] netfilter: nat: constify rhashtable_params Arvind Yadav
2017-09-08 11:46 ` Pablo Neira Ayuso
2017-09-08 17:47 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908174718.GA1727@salvia \
--to=pablo@netfilter.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).