From: Pavel Machek <pavel@ucw.cz>
To: Tristram.Ha@microchip.com
Cc: andrew@lunn.ch, muvarov@gmail.com, nathan.leigh.conrad@gmail.com,
vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Woojung.Huh@microchip.com
Subject: Re: [PATCH RFC 3/5] Add KSZ8795 switch driver
Date: Fri, 8 Sep 2017 23:57:35 +0200 [thread overview]
Message-ID: <20170908215735.GF27428@amd> (raw)
In-Reply-To: <93AF473E2DA327428DE3D46B72B1E9FD41121E3D@CHN-SV-EXMX02.mchp-main.com>
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
Hi!
> > > + default:
> > > + processed = false;
> > > + break;
> > > + }
> > > + if (processed)
> > > + *val = data;
> > > +}
> >
> > Similar code will be needed by other drivers, right?
>
> Although KSZ8795 and KSZ8895 may use the same code, the other
> chips will have different code.
Ok, please make sure code is shared between these two.
Thansk,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-09-08 21:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 21:17 [PATCH RFC 3/5] Add KSZ8795 switch driver Tristram.Ha
2017-09-07 22:36 ` Andrew Lunn
2017-09-18 20:27 ` Tristram.Ha
2017-09-28 18:40 ` Pavel Machek
2017-09-28 18:45 ` Florian Fainelli
2017-09-29 18:56 ` Tristram.Ha
2017-09-28 19:34 ` Andrew Lunn
2017-09-29 9:14 ` David Laight
2017-09-29 12:12 ` Andrew Lunn
2017-09-29 18:24 ` Tristram.Ha
2017-09-29 18:53 ` Andrew Lunn
2017-09-29 19:19 ` Tristram.Ha
2017-09-29 20:39 ` Andrew Lunn
2017-09-08 9:18 ` Pavel Machek
2017-09-08 17:54 ` Tristram.Ha
2017-09-08 18:32 ` Andrew Lunn
2017-09-08 18:35 ` Woojung.Huh
2017-09-08 21:57 ` Pavel Machek [this message]
2017-09-09 1:44 ` Tristram.Ha
2017-09-09 15:45 ` Andrew Lunn
2017-09-28 15:24 ` Pavel Machek
2017-09-29 18:45 ` Tristram.Ha
2017-10-01 7:21 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170908215735.GF27428@amd \
--to=pavel@ucw.cz \
--cc=Tristram.Ha@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muvarov@gmail.com \
--cc=nathan.leigh.conrad@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).