From: David Miller <davem@davemloft.net>
To: thomas@m3y3r.de
Cc: jon.maloy@ericsson.com, ying.xue@windriver.com,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tipc: Use bsearch library function
Date: Mon, 11 Sep 2017 14:30:25 -0700 (PDT) [thread overview]
Message-ID: <20170911.143025.555018840006192902.davem@davemloft.net> (raw)
In-Reply-To: <20170909031819.13622-1-thomas@m3y3r.de>
From: Thomas Meyer <thomas@m3y3r.de>
Date: Sat, 9 Sep 2017 05:18:19 +0200
> @@ -168,6 +169,18 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea
> return nseq;
> }
>
> +static int nameseq_find_subseq_cmp(const void *key, const void *elt)
> +{
> + u32 instance = *(u32 *)key;
> + struct sub_seq *sseq = (struct sub_seq *)elt;
Please order local variables from longest to shortest (ie. reverse
christmas tree).
Thank you.
next prev parent reply other threads:[~2017-09-11 21:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 3:18 [PATCH] tipc: Use bsearch library function Thomas Meyer
2017-09-11 21:30 ` David Miller [this message]
2017-09-12 9:24 ` David Laight
2017-09-16 7:50 ` [PATCH V2] " Thomas Meyer
2017-09-16 9:02 ` Ying Xue
2017-09-16 9:26 ` Joe Perches
2017-09-16 9:36 ` Ying Xue
2017-09-16 9:58 ` Joe Perches
2017-09-16 10:10 ` Ying Xue
2017-09-16 10:17 ` Joe Perches
2017-09-16 13:20 ` Jon Maloy
2017-09-17 15:00 ` Thomas Meyer
2017-09-17 16:27 ` Jon Maloy
2017-09-17 21:15 ` Joe Perches
2017-09-19 1:08 ` Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170911.143025.555018840006192902.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thomas@m3y3r.de \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).