From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net 0/3] nfp: wait more carefully for card init
Date: Wed, 13 Sep 2017 18:53:08 +0200 [thread overview]
Message-ID: <20170913185308.7c64275e@cakuba.netronome.com> (raw)
In-Reply-To: <20170913.093902.570914704132982694.davem@davemloft.net>
On Wed, 13 Sep 2017 09:39:02 -0700 (PDT), David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Wed, 13 Sep 2017 08:51:28 -0700
>
> > The first patch is a small fix for flower offload, we need a whitelist
> > of supported matches, otherwise the unsupported ones will be ignored.
> >
> > The second and the third patch are adding wait/polling to the probe path.
> > We had reports of driver failing probe because it couldn't find the
> > control process (NSP) on the card. Turns out the NSP will only announce
> > its existence after it's fully initialized. Until now we assumed it
> > will be reachable, just not processing commands (hence we wait for
> > a NOOP command to execute successfully).
>
> Please build test your changes and look at what the compiler says:
>
> drivers/net/ethernet/netronome/nfp/nfp_main.c: In function ‘nfp_fw_unload’:
> drivers/net/ethernet/netronome/nfp/nfp_main.c:395:10: warning: ‘return’ with a value, in function returning void
> return err;
> ^~~
> drivers/net/ethernet/netronome/nfp/nfp_main.c:388:13: note: declared here
> static void nfp_fw_unload(struct nfp_pf *pf)
> ^~~~~~~~~~~~~
Sorry about that!
prev parent reply other threads:[~2017-09-13 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 15:51 [PATCH net 0/3] nfp: wait more carefully for card init Jakub Kicinski
2017-09-13 15:51 ` [PATCH net 1/3] nfp: add whitelist of supported flow dissector Jakub Kicinski
2017-09-13 15:51 ` [PATCH net 2/3] nfp: wait for board state before talking to the NSP Jakub Kicinski
2017-09-13 15:51 ` [PATCH net 3/3] nfp: wait for the NSP resource to appear on boot Jakub Kicinski
2017-09-13 16:39 ` [PATCH net 0/3] nfp: wait more carefully for card init David Miller
2017-09-13 16:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913185308.7c64275e@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox