From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] tg3: clean up redundant initialization of tnapi Date: Thu, 14 Sep 2017 10:00:41 -0700 (PDT) Message-ID: <20170914.100041.1507992015904111255.davem@davemloft.net> References: <20170914160125.11007-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: siva.kallam@broadcom.com, prashant@broadcom.com, mchan@broadcom.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20170914160125.11007-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Thu, 14 Sep 2017 17:01:25 +0100 > From: Colin Ian King > > tnapi is being initialized and then immediately updated and > hence the initialiation is redundant. Clean up the warning > by moving the declaration and initialization to the inside > of the for-loop. > > Cleans up clang scan-build warning: > warning: Value stored to 'tnapi' during its initialization is never read > > Signed-off-by: Colin Ian King Applied.