* [PATCH] qed: remove unnecessary call to memset
@ 2017-09-12 11:19 Himanshu Jha
2017-09-13 9:15 ` Kalluru, Sudarsana
2017-09-15 21:02 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Himanshu Jha @ 2017-09-12 11:19 UTC (permalink / raw)
To: Yuval.Mintz
Cc: Ariel.Elior, everest-linux-l2, netdev, linux-kernel, Himanshu Jha
call to memset to assign 0 value immediately after allocating
memory with kzalloc is unnecesaary as kzalloc allocates the memory
filled with 0 value.
Semantic patch used to resolve this issue:
@@
expression e,e2; constant c;
statement S;
@@
e = kzalloc(e2, c);
if(e == NULL) S
- memset(e, 0, e2);
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index eaca457..8f6ccc0 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -1244,7 +1244,6 @@ int qed_dcbx_get_config_params(struct qed_hwfn *p_hwfn,
if (!dcbx_info)
return -ENOMEM;
- memset(dcbx_info, 0, sizeof(*dcbx_info));
rc = qed_dcbx_query_params(p_hwfn, dcbx_info, QED_DCBX_OPERATIONAL_MIB);
if (rc) {
kfree(dcbx_info);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] qed: remove unnecessary call to memset
2017-09-12 11:19 [PATCH] qed: remove unnecessary call to memset Himanshu Jha
@ 2017-09-13 9:15 ` Kalluru, Sudarsana
2017-09-15 21:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Kalluru, Sudarsana @ 2017-09-13 9:15 UTC (permalink / raw)
To: Himanshu Jha, Mintz, Yuval
Cc: Elior, Ariel, Dept-Eng Everest Linux L2, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
-----Original Message-----
From: Himanshu Jha [mailto:himanshujha199640@gmail.com]
Sent: 12 September 2017 16:49
To: Mintz, Yuval <Yuval.Mintz@cavium.com>
Cc: Elior, Ariel <Ariel.Elior@cavium.com>; Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@cavium.com>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Himanshu Jha <himanshujha199640@gmail.com>
Subject: [PATCH] qed: remove unnecessary call to memset
call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value.
Semantic patch used to resolve this issue:
@@
expression e,e2; constant c;
statement S;
@@
e = kzalloc(e2, c);
if(e == NULL) S
- memset(e, 0, e2);
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index eaca457..8f6ccc0 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -1244,7 +1244,6 @@ int qed_dcbx_get_config_params(struct qed_hwfn *p_hwfn,
if (!dcbx_info)
return -ENOMEM;
- memset(dcbx_info, 0, sizeof(*dcbx_info));
rc = qed_dcbx_query_params(p_hwfn, dcbx_info, QED_DCBX_OPERATIONAL_MIB);
if (rc) {
kfree(dcbx_info);
--
2.7.4
Acked-by: Sudarsana Kalluru <sudarsana.kalluru@cavium.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: remove unnecessary call to memset
2017-09-12 11:19 [PATCH] qed: remove unnecessary call to memset Himanshu Jha
2017-09-13 9:15 ` Kalluru, Sudarsana
@ 2017-09-15 21:02 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-09-15 21:02 UTC (permalink / raw)
To: himanshujha199640
Cc: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev, linux-kernel
From: Himanshu Jha <himanshujha199640@gmail.com>
Date: Tue, 12 Sep 2017 16:49:22 +0530
> call to memset to assign 0 value immediately after allocating
> memory with kzalloc is unnecesaary as kzalloc allocates the memory
> filled with 0 value.
>
> Semantic patch used to resolve this issue:
>
> @@
> expression e,e2; constant c;
> statement S;
> @@
>
> e = kzalloc(e2, c);
> if(e == NULL) S
> - memset(e, 0, e2);
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-15 21:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-12 11:19 [PATCH] qed: remove unnecessary call to memset Himanshu Jha
2017-09-13 9:15 ` Kalluru, Sudarsana
2017-09-15 21:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).