From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] sctp: do not mark sk dumped when inet_sctp_diag_fill returns err Date: Fri, 15 Sep 2017 14:51:34 -0700 (PDT) Message-ID: <20170915.145134.235758682095715785.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com To: lucien.xin@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:57886 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751563AbdIOVvf (ORCPT ); Fri, 15 Sep 2017 17:51:35 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long Date: Fri, 15 Sep 2017 11:02:48 +0800 > sctp_diag would not actually dump out sk/asoc if inet_sctp_diag_fill > returns err, in which case it shouldn't mark sk dumped by setting > cb->args[3] as 1 in sctp_sock_dump(). > > Otherwise, it could cause some asocs to have no parent's sk dumped > in 'ss --sctp'. > > So this patch is to not set cb->args[3] when inet_sctp_diag_fill() > returns err in sctp_sock_dump(). > > Fixes: 8f840e47f190 ("sctp: add the sctp_diag.c file") > Signed-off-by: Xin Long Applied.