* [PATCH] Documentation: networking: fix ASCII art in switchdev.txt
@ 2017-09-16 20:10 Randy Dunlap
2017-09-16 21:00 ` Pavel Machek
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Randy Dunlap @ 2017-09-16 20:10 UTC (permalink / raw)
To: netdev@vger.kernel.org, David Miller, Pavel Machek
Cc: Andrew Lunn, Andreas Schwab, Jiri Pirko, Scott Feldman
From: Randy Dunlap <rdunlap@infradead.org>
Fix ASCII art in Documentation/networking/switchdev.txt:
Change non-ASCII "spaces" to ASCII spaces.
Change 2 erroneous '+' characters in ASCII art to '-' (at the '*'
characters below):
line 32:
+--+----+----+----+-*--+----+---+ +-----+-----+
line 41:
+--------------+---*------------+
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Documentation/networking/switchdev.txt | 64 +++++++++++------------
1 file changed, 32 insertions(+), 32 deletions(-)
--- lnx-413.orig/Documentation/networking/switchdev.txt
+++ lnx-413/Documentation/networking/switchdev.txt
@@ -13,42 +13,42 @@ an example setup using a data-center-cla
with SR-IOV or soft switches, such as OVS, are possible.
- User-space tools
+ User-space tools
- user space |
- +-------------------------------------------------------------------+
- kernel | Netlink
- |
- +--------------+-------------------------------+
- | Network stack |
- | (Linux) |
- | |
- +----------------------------------------------+
+ user space |
+ +-------------------------------------------------------------------+
+ kernel | Netlink
+ |
+ +--------------+-------------------------------+
+ | Network stack |
+ | (Linux) |
+ | |
+ +----------------------------------------------+
sw1p2 sw1p4 sw1p6
- sw1p1 + sw1p3 + sw1p5 + eth1
- + | + | + | +
- | | | | | | |
- +--+----+----+----+-+--+----+---+ +-----+-----+
- | Switch driver | | mgmt |
- | (this document) | | driver |
- | | | |
- +--------------+----------------+ +-----------+
- |
- kernel | HW bus (eg PCI)
- +-------------------------------------------------------------------+
- hardware |
- +--------------+---+------------+
- | Switch device (sw1) |
- | +----+ +--------+
- | | v offloaded data path | mgmt port
- | | | |
- +--|----|----+----+----+----+---+
- | | | | | |
- + + + + + +
- p1 p2 p3 p4 p5 p6
+ sw1p1 + sw1p3 + sw1p5 + eth1
+ + | + | + | +
+ | | | | | | |
+ +--+----+----+----+----+----+---+ +-----+-----+
+ | Switch driver | | mgmt |
+ | (this document) | | driver |
+ | | | |
+ +--------------+----------------+ +-----------+
+ |
+ kernel | HW bus (eg PCI)
+ +-------------------------------------------------------------------+
+ hardware |
+ +--------------+----------------+
+ | Switch device (sw1) |
+ | +----+ +--------+
+ | | v offloaded data path | mgmt port
+ | | | |
+ +--|----|----+----+----+----+---+
+ | | | | | |
+ + + + + + +
+ p1 p2 p3 p4 p5 p6
- front-panel ports
+ front-panel ports
Fig 1.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: networking: fix ASCII art in switchdev.txt
2017-09-16 20:10 [PATCH] Documentation: networking: fix ASCII art in switchdev.txt Randy Dunlap
@ 2017-09-16 21:00 ` Pavel Machek
2017-09-16 21:29 ` Andrew Lunn
2017-09-18 23:39 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2017-09-16 21:00 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev@vger.kernel.org, David Miller, Andrew Lunn, Andreas Schwab,
Jiri Pirko, Scott Feldman
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Sat 2017-09-16 13:10:06, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix ASCII art in Documentation/networking/switchdev.txt:
>
> Change non-ASCII "spaces" to ASCII spaces.
>
> Change 2 erroneous '+' characters in ASCII art to '-' (at the '*'
> characters below):
>
> line 32:
> +--+----+----+----+-*--+----+---+ +-----+-----+
> line 41:
> +--------------+---*------------+
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: networking: fix ASCII art in switchdev.txt
2017-09-16 20:10 [PATCH] Documentation: networking: fix ASCII art in switchdev.txt Randy Dunlap
2017-09-16 21:00 ` Pavel Machek
@ 2017-09-16 21:29 ` Andrew Lunn
2017-09-18 23:39 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2017-09-16 21:29 UTC (permalink / raw)
To: Randy Dunlap
Cc: netdev@vger.kernel.org, David Miller, Pavel Machek,
Andreas Schwab, Jiri Pirko, Scott Feldman
On Sat, Sep 16, 2017 at 01:10:06PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix ASCII art in Documentation/networking/switchdev.txt:
>
> Change non-ASCII "spaces" to ASCII spaces.
>
> Change 2 erroneous '+' characters in ASCII art to '-' (at the '*'
> characters below):
>
> line 32:
> +--+----+----+----+-*--+----+---+ +-----+-----+
> line 41:
> +--------------+---*------------+
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
A much more readable patch. Thanks
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: networking: fix ASCII art in switchdev.txt
2017-09-16 20:10 [PATCH] Documentation: networking: fix ASCII art in switchdev.txt Randy Dunlap
2017-09-16 21:00 ` Pavel Machek
2017-09-16 21:29 ` Andrew Lunn
@ 2017-09-18 23:39 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-09-18 23:39 UTC (permalink / raw)
To: rdunlap; +Cc: netdev, pavel, andrew, schwab, jiri, sfeldma
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sat, 16 Sep 2017 13:10:06 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix ASCII art in Documentation/networking/switchdev.txt:
>
> Change non-ASCII "spaces" to ASCII spaces.
>
> Change 2 erroneous '+' characters in ASCII art to '-' (at the '*'
> characters below):
>
> line 32:
> +--+----+----+----+-*--+----+---+ +-----+-----+
> line 41:
> +--------------+---*------------+
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thanks Randy.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-18 23:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-16 20:10 [PATCH] Documentation: networking: fix ASCII art in switchdev.txt Randy Dunlap
2017-09-16 21:00 ` Pavel Machek
2017-09-16 21:29 ` Andrew Lunn
2017-09-18 23:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).