From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ville.syrjala@linux.intel.com, edumazet@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net] 8139too: revisit napi_complete_done() usage
Date: Mon, 18 Sep 2017 20:57:29 -0700 (PDT) [thread overview]
Message-ID: <20170918.205729.1447641244948185208.davem@davemloft.net> (raw)
In-Reply-To: <1505765023.29839.32.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 18 Sep 2017 13:03:43 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> It seems we have to be more careful in napi_complete_done()
> use. This patch is not a revert, as it seems we can
> avoid bug that Ville reported by moving the napi_complete_done()
> test in the spinlock section.
>
> Many thanks to Ville for detective work and all tests.
>
> Fixes: 617f01211baf ("8139too: use napi_complete_done()")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Applied and queued up for -stable.
next prev parent reply other threads:[~2017-09-19 3:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 18:17 [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()") Ville Syrjälä
2017-04-07 18:38 ` Eric Dumazet
2017-04-07 18:42 ` David Miller
2017-04-08 10:23 ` Francois Romieu
2017-04-10 14:22 ` tedheadster
2017-04-10 14:55 ` Eric Dumazet
2017-04-10 12:11 ` Ville Syrjälä
2017-09-18 19:46 ` Ville Syrjälä
2017-09-18 19:52 ` Eric Dumazet
2017-09-19 12:45 ` Ville Syrjälä
2017-09-19 13:51 ` Eric Dumazet
2017-09-18 20:03 ` [PATCH net] 8139too: revisit napi_complete_done() usage Eric Dumazet
2017-09-19 3:57 ` David Miller [this message]
2018-01-22 17:27 ` tedheadster
2018-01-22 19:03 ` Eric Dumazet
2017-06-19 14:44 ` [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()") Michal Kubecek
2017-07-05 19:53 ` Ville Syrjälä
2017-04-21 11:40 ` Ville Syrjälä
2017-04-21 13:29 ` Eric Dumazet
2017-04-21 15:09 ` Eric Dumazet
2017-04-21 15:34 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918.205729.1447641244948185208.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).