From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Subject: [PATCH] sunrpc: remove redundant initialization of sock Date: Mon, 18 Sep 2017 12:21:14 +0100 Message-ID: <20170918112114.29429-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org To: "J . Bruce Fields" , Jeff Layton , Trond Myklebust , Anna Schumaker , "David S . Miller" , linux-nfs@vger.kernel.org Return-path: Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin Ian King sock is being initialized and then being almost immediately updated hence the initialized value is not being used and is redundant. Remove the initialization. Cleans up clang warning: warning: Value stored to 'sock' during its initialization is never read Signed-off-by: Colin Ian King --- net/sunrpc/xprtsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 9b5de31aa429..c1841f234a71 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -2203,7 +2203,7 @@ static void xs_udp_setup_socket(struct work_struct *work) struct sock_xprt *transport = container_of(work, struct sock_xprt, connect_worker.work); struct rpc_xprt *xprt = &transport->xprt; - struct socket *sock = transport->sock; + struct socket *sock; int status = -EIO; sock = xs_create_sock(xprt, transport, -- 2.14.1