* [PATCH] net: ethernet: aquantia: default to no in config
@ 2017-09-19 22:43 Vito Caputo
2017-09-19 22:52 ` David Miller
2017-09-20 10:28 ` Sergei Shtylyov
0 siblings, 2 replies; 5+ messages in thread
From: Vito Caputo @ 2017-09-19 22:43 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev
NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
obviously inappropriate.
---
drivers/net/ethernet/aquantia/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/Kconfig b/drivers/net/ethernet/aquantia/Kconfig
index cdf78e069a39..6167b13cf349 100644
--- a/drivers/net/ethernet/aquantia/Kconfig
+++ b/drivers/net/ethernet/aquantia/Kconfig
@@ -4,7 +4,7 @@
config NET_VENDOR_AQUANTIA
bool "aQuantia devices"
- default y
+ default n
---help---
Set this to y if you have an Ethernet network cards that uses the aQuantia
AQC107/AQC108 chipset.
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: ethernet: aquantia: default to no in config
2017-09-19 22:43 [PATCH] net: ethernet: aquantia: default to no in config Vito Caputo
@ 2017-09-19 22:52 ` David Miller
2017-09-19 23:02 ` vcaputo
2017-09-20 10:28 ` Sergei Shtylyov
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2017-09-19 22:52 UTC (permalink / raw)
To: vcaputo; +Cc: linux-kernel, netdev
From: Vito Caputo <vcaputo@pengaru.com>
Date: Tue, 19 Sep 2017 15:43:15 -0700
> NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
> obviously inappropriate.
It is appropriate.
We make all vendor guards default to yes.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: ethernet: aquantia: default to no in config
2017-09-19 22:52 ` David Miller
@ 2017-09-19 23:02 ` vcaputo
2017-09-19 22:59 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: vcaputo @ 2017-09-19 23:02 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev
On Tue, Sep 19, 2017 at 03:52:31PM -0700, David Miller wrote:
> From: Vito Caputo <vcaputo@pengaru.com>
> Date: Tue, 19 Sep 2017 15:43:15 -0700
>
> > NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
> > obviously inappropriate.
>
> It is appropriate.
>
> We make all vendor guards default to yes.
Thanks for the quick response.
Out of curiosity, what's the rationale for that decision?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: ethernet: aquantia: default to no in config
2017-09-19 22:43 [PATCH] net: ethernet: aquantia: default to no in config Vito Caputo
2017-09-19 22:52 ` David Miller
@ 2017-09-20 10:28 ` Sergei Shtylyov
1 sibling, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2017-09-20 10:28 UTC (permalink / raw)
To: Vito Caputo, linux-kernel; +Cc: netdev
Hello!
On 9/20/2017 1:43 AM, Vito Caputo wrote:
> NET_VENDOR_AQUANTIA was "default y" for some reason, which seems
> obviously inappropriate.
> ---
> drivers/net/ethernet/aquantia/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aquantia/Kconfig b/drivers/net/ethernet/aquantia/Kconfig
> index cdf78e069a39..6167b13cf349 100644
> --- a/drivers/net/ethernet/aquantia/Kconfig
> +++ b/drivers/net/ethernet/aquantia/Kconfig
> @@ -4,7 +4,7 @@
>
> config NET_VENDOR_AQUANTIA
> bool "aQuantia devices"
> - default y
> + default n
Just remove it -- 'n' is the default default. :-)
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-20 10:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-19 22:43 [PATCH] net: ethernet: aquantia: default to no in config Vito Caputo
2017-09-19 22:52 ` David Miller
2017-09-19 23:02 ` vcaputo
2017-09-19 22:59 ` David Miller
2017-09-20 10:28 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).