From: David Miller <davem@davemloft.net>
To: yanhaishuang@cmss.chinamobile.com
Cc: kuznet@ms2.inr.ac.ru, edumazet@google.com, weiwan@google.com,
lucab@debian.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob
Date: Wed, 20 Sep 2017 14:22:27 -0700 (PDT) [thread overview]
Message-ID: <20170920.142227.65942571438912956.davem@davemloft.net> (raw)
In-Reply-To: <1505813896-12121-1-git-send-email-yanhaishuang@cmss.chinamobile.com>
From: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Date: Tue, 19 Sep 2017 17:38:14 +0800
> - if ((sysctl_tcp_fastopen & TFO_SERVER_WO_SOCKOPT1) &&
> - (sysctl_tcp_fastopen & TFO_SERVER_ENABLE) &&
> + tcp_fastopen = sock_net(sk)->ipv4.sysctl_tcp_fastopen;
^^
Please change that to one space.
And also please provide an appropriate "[PATCH vX 0/3] " header
posting when you respin this series.
> @@ -282,18 +280,19 @@ struct sock *tcp_try_fastopen(struct sock *sk, struct sk_buff *skb,
> struct tcp_fastopen_cookie valid_foc = { .len = -1 };
> bool syn_data = TCP_SKB_CB(skb)->end_seq != TCP_SKB_CB(skb)->seq + 1;
> struct sock *child;
> + int tcp_fastopen = sock_net(sk)->ipv4.sysctl_tcp_fastopen;
Please order local variables from longest to shortest line (aka. reverse
christmas tree format).
next prev parent reply other threads:[~2017-09-20 21:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 9:38 [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob Haishuang Yan
2017-09-19 9:38 ` [Patch v3 2/3] ipv4: Namespaceify tcp_fastopen_key knob Haishuang Yan
2017-09-20 21:25 ` David Miller
2017-09-19 9:38 ` [Patch v3 3/3] ipv4: Namespaceify tcp_fastopen_blackhole_timeout knob Haishuang Yan
2017-09-20 21:22 ` David Miller [this message]
2017-09-21 1:55 ` [Patch v3 1/3] ipv4: Namespaceify tcp_fastopen knob 严海双
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920.142227.65942571438912956.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lucab@debian.org \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
--cc=yanhaishuang@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).